Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sizzle wiki as API page #1224

Open
mgol opened this issue Apr 24, 2023 · 3 comments
Open

Add Sizzle wiki as API page #1224

mgol opened this issue Apr 24, 2023 · 3 comments
Milestone

Comments

@mgol
Copy link
Member

mgol commented Apr 24, 2023

The main page should document jQuery.expr.pseudos but we should also have shorter pages for jQuery.expr[ ":" ] & jQuery.expr.filters as its deprecated aliases.

Sizzle docs can be a starting point as jQuery.expr is an alias of Sizzle.selectors in jQuery <3.7.0:
https://github.com/jquery/sizzle/wiki#sizzleselectorspseudosname--function-elem--

Note: Make sure legacy pseudos are documented as deprecated & removed in 4.0 (see jquery/jquery#5137)

@mgol mgol added this to the 3.0.0 milestone Apr 24, 2023
@timmywil
Copy link
Member

I don't know if it should. While the support probably can't go away, custom pseudos aren't necessarily something I'd want to encourage. It's better to use .filter() after selection.

@mgol mgol added the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Apr 25, 2023
@mgol
Copy link
Member Author

mgol commented Apr 25, 2023

OK, let's discuss further at the team meeting. 🙂 cc @gibson042

@timmywil timmywil removed the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label May 22, 2023
@timmywil
Copy link
Member

We're going to change this issue to include the Sizzle wiki as its own API page, rather than document everything separately.

@timmywil timmywil changed the title Document jQuery.expr.pseudos, jQuery.expr[ ":" ] & jQuery.expr.filters Add Sizzle wiki as API page May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants