Skip to content

Certain cell failures are not detected #190

@ceball

Description

@ceball

Inherited from nbval. E.g. test for bad magics is currently marked "known fail":

# TODO: see https://github.com/computationalmodelling/nbval/issues/147
class TestSomeSanity(_TestCellTests):
NBNAME = BROKEN_MAGICS
@pytest.mark.xfail(reason="error messages on shell channel are ignored by nbval")
def test_bad_magic_does_let_everything_pass(self):

(note: typo in above method name - "does not")

There might be other cases too, haven't investigated.

Metadata

Metadata

Assignees

No one assigned

    Labels

    part: cell testsRelating to cell testing componenttype: bugConcrete, reproducible bugs

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions