From 4fd4cc22deb4c5b69d7a27b5cfeee2188e79d6de Mon Sep 17 00:00:00 2001 From: Cody Batt Date: Wed, 15 Aug 2018 12:45:57 -0600 Subject: [PATCH] Remove nullable and update release notes --- ReleaseNotes.md | 3 +++ source/Draft/Requests/GetRequest.cs | 2 +- source/Draft/Requests/IGetRequest.cs | 4 ++-- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/ReleaseNotes.md b/ReleaseNotes.md index 627b9e5..998daae 100644 --- a/ReleaseNotes.md +++ b/ReleaseNotes.md @@ -1,3 +1,6 @@ +### new in 1.0.7.2 (Release 2018/08/15) +* New: IGetRequest.WithTimeout - Set HTTP timeout on per-request basis + ### new in 1.0.7.1 (Release 2018/08/09) * Fixed: Assembly version should match Nuget package version diff --git a/source/Draft/Requests/GetRequest.cs b/source/Draft/Requests/GetRequest.cs index fe84b26..c942d4d 100644 --- a/source/Draft/Requests/GetRequest.cs +++ b/source/Draft/Requests/GetRequest.cs @@ -55,7 +55,7 @@ public IGetRequest WithRecursive(bool recursive = true) return this; } - public IGetRequest WithTimeout(TimeSpan? timeout) + public IGetRequest WithTimeout(TimeSpan timeout) { _httpTimeout = timeout; return this; diff --git a/source/Draft/Requests/IGetRequest.cs b/source/Draft/Requests/IGetRequest.cs index 414b000..4c7a848 100644 --- a/source/Draft/Requests/IGetRequest.cs +++ b/source/Draft/Requests/IGetRequest.cs @@ -39,9 +39,9 @@ public interface IGetRequest IGetRequest WithRecursive(bool recursive = true); /// - /// Override the default timeout for this request. null results in the HttpClient default timeout. + /// Override the default timeout for this request. /// - IGetRequest WithTimeout(TimeSpan? timeout); + IGetRequest WithTimeout(TimeSpan timeout); } }