Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with vim-fugitive plugin #41

Open
still-dreaming-1 opened this issue Feb 28, 2016 · 3 comments
Open

Incompatible with vim-fugitive plugin #41

still-dreaming-1 opened this issue Feb 28, 2016 · 3 comments

Comments

@still-dreaming-1
Copy link

If I have vim-phpqa and vim-fugitive installed, a feature of vim-fugitive does not work. I run the :Gstatus command in a scenario where the status buffer will show an unstaged, modified php file. Move the cursor to that file, and then press D. This tries to run something similar to vim difftool on the latest version of the file and the checkout version of the file. Some windows open up, and the window that is supposed to show the the checked out version of the file with highlighted differences instead shows this phpqa related error message:

"www/ACSmanager/AcceptManuallyEnteredAmr.php" 44L, 2009C                                                                                                                                      
Error detected while processing function Phpqa#PhpLint:                                                                                                                                       
line    8:                                                                                                                                                                                    
E684: list index out of range: 0                                                                                                                                                              
E116: Invalid arguments for function match(l:php_list[0],"No syntax errors") == -1                                                                                                            
E15: Invalid expression: 0 != v:shell_error && match(l:php_list[0],"No syntax errors") == -1

Happening in the latest version of Neovim. Something similar happens in an older version of Vim I tested. I have the latest version of vim-phpqa and vim-fugitive.

@still-dreaming-1
Copy link
Author

Here is what the vim-fugitive maintainer had to say: tpope/vim-fugitive#754 (comment)

If phpqa is blowing up it's because phpqa made some assumptions that don't hold true for fugitive buffers.

@PickRelated
Copy link

Totally confirm. Makes huge pain in the booty for me. Each time I want to see a git diff, I have to turn phpqa off and reboot vim. Then not to forget turn it back on before committing.

@PickRelated
Copy link

But why complain? Created a pull request with a fix. :) Please, check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants