Why do we have to inject jQuery just to have the test pass?

[astridx]

I have read

#32707

and

#32740 (comment)

Therefore I suspect that it is about this line:

joomla-cms/administrator/components/com_content/tmpl/articles/default.php

Line 30 in 83a61f1

HTMLHelper::_('jquery.framework');

I commented out this line and ran the unit tests and the codeception tests for com_content.
No error occurred.

unit_tests.txt
com_content.txt

[Fedik]

Please make a PR for removing it, then we will see 😉

[Fedik]

yea it a issue with joomla-projects/joomla-browser

[dgrammatiko]

BTW jQuery was injected just to have passing tests in administrator/components/com_content/tmpl/articles/default.php and administrator/components/com_fields/tmpl/fields/default.php according to #31990

[Fedik]

well, I have opened the issue joomla-projects/joomla-browser#215

[dgrammatiko]

I think the function should be duplicated with another name and without jQuery and use in the 4.0 branch but the original needs to stay untouched for the v3 branch. Unless if the vanilla code could work on both branches. BTW it's codeception that fails not unit tests

[astridx]

Thank you. Now I understand. In my tests, this was not problematic. But in other places it throws errors for me too.

[astridx]

I have just checked it. It's not true that we no longer use jQuery in Joomla 4. I just found a place here.

joomla-cms/build/media_source/system/js/searchtools.es6.js

Line 253 in c78ef2f

if (window.jQuery && window.jQuery.chosen) {

[dgrammatiko]

That's a special case and it goes like if jQuery is loaded and also chosen is loaded, so we are not using jQuery we just cover also that case.

Actually this probably doesn't even work and honestly Joomla 4 should not ship dead code (chosen is dead for some years now)