Skip to content

Commit 9a8db52

Browse files
Merge bitcoin-core#1582: cmake, test: Add secp256k1_ prefix to test names
87384f5 cmake, test: Add `secp256k1_` prefix to test names (Hennadii Stepanov) Pull request description: This PR improves regex matching options when using `ctest` in downstream projects, such as Bitcoin Core. For instance, a downstream project users can filter their tests like that: ``` ctest --tests-regex "secp256k1" ``` or ``` ctest --exclude-regex "secp256k1" ``` A `ctest` log with this PR: ``` $ ctest --test-dir build -j 16 Internal ctest changing into directory: /home/hebasto/git/secp256k1/secp256k1/build Test project /home/hebasto/git/secp256k1/secp256k1/build Start 1: secp256k1_noverify_tests Start 2: secp256k1_tests Start 3: secp256k1_exhaustive_tests Start 4: secp256k1_ecdsa_example Start 5: secp256k1_ecdh_example Start 6: secp256k1_schnorr_example Start 7: secp256k1_ellswift_example Start 8: secp256k1_musig_example 1/8 Test #4: secp256k1_ecdsa_example .......... Passed 0.00 sec 2/8 Test #5: secp256k1_ecdh_example ........... Passed 0.00 sec 3/8 Test #6: secp256k1_schnorr_example ........ Passed 0.00 sec 4/8 Test #7: secp256k1_ellswift_example ....... Passed 0.00 sec 5/8 Test #8: secp256k1_musig_example .......... Passed 0.00 sec 6/8 Test #3: secp256k1_exhaustive_tests ....... Passed 6.19 sec 7/8 Test #1: secp256k1_noverify_tests ......... Passed 38.83 sec 8/8 Test #2: secp256k1_tests .................. Passed 91.66 sec 100% tests passed, 0 tests failed out of 8 Total Test time (real) = 91.67 sec ``` ACKs for top commit: theuni: utACK 87384f5 real-or-random: utACK 87384f5 Tree-SHA512: d8e46558cf58c9c660544b7bdfed24c991eb3e120b6511aa3968f509190130e498749a3c4dbabc87a7f22f0aa0056c6bcd3fc6c44f5eb131588945d593546840
2 parents 1464f15 + 87384f5 commit 9a8db52

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

examples/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ function(add_example name)
99
$<$<PLATFORM_ID:Windows>:bcrypt>
1010
)
1111
set(test_name ${name}_example)
12-
add_test(NAME ${test_name} COMMAND ${target_name})
12+
add_test(NAME secp256k1_${test_name} COMMAND ${target_name})
1313
endfunction()
1414

1515
add_example(ecdsa)

src/CMakeLists.txt

+3-3
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,12 @@ endif()
8787
if(SECP256K1_BUILD_TESTS)
8888
add_executable(noverify_tests tests.c)
8989
target_link_libraries(noverify_tests secp256k1_precomputed secp256k1_asm)
90-
add_test(NAME noverify_tests COMMAND noverify_tests)
90+
add_test(NAME secp256k1_noverify_tests COMMAND noverify_tests)
9191
if(NOT CMAKE_BUILD_TYPE STREQUAL "Coverage")
9292
add_executable(tests tests.c)
9393
target_compile_definitions(tests PRIVATE VERIFY)
9494
target_link_libraries(tests secp256k1_precomputed secp256k1_asm)
95-
add_test(NAME tests COMMAND tests)
95+
add_test(NAME secp256k1_tests COMMAND tests)
9696
endif()
9797
endif()
9898

@@ -101,7 +101,7 @@ if(SECP256K1_BUILD_EXHAUSTIVE_TESTS)
101101
add_executable(exhaustive_tests tests_exhaustive.c)
102102
target_link_libraries(exhaustive_tests secp256k1_asm)
103103
target_compile_definitions(exhaustive_tests PRIVATE $<$<NOT:$<CONFIG:Coverage>>:VERIFY>)
104-
add_test(NAME exhaustive_tests COMMAND exhaustive_tests)
104+
add_test(NAME secp256k1_exhaustive_tests COMMAND exhaustive_tests)
105105
endif()
106106

107107
if(SECP256K1_BUILD_CTIME_TESTS)

0 commit comments

Comments
 (0)