Feature flags setup, and implementation of SKIP_IDENTTITY_CREATION and SKIP_ENTROPY_COLLECTION #1410
Conversation
|
I'm not sure what would fail with a 'dummy identity' in this way. I tried adding a claim and it seemed to work, but haven't tested further yet. |
mnzaki
force-pushed
the
1407/feature_flags
branch
from
222027b to
4aa206c
Compare
add babel-plugin-transform-inline-environment-variables use process.env['NODE_ENV'] in src/config.ts
- run unit tests under proper NODE_ENV - fix fuelKeyWithEther call/test - minor typescript issues
It needs to be transpiled, but also the global window variable was breaking this code: https://github.com/typeorm/typeorm/blob/e4de0403e1f666639c0198e216409f997121c1e8/src/platform/BrowserPlatformTools.template#L20 Also add ConnectionOptions type back to the config object
mnzaki
force-pushed
the
1407/feature_flags
branch
from
4aa206c to
92ee5ca
Compare
mnzaki
requested review from
VolkerSchiewe and
saifahn
and removed request for
VolkerSchiewe
| @@ -58,7 +60,9 @@ export class EntropyContainer extends React.Component<Props, State> { | |||
| } | |||
|
|
|||
| private updateEntropyProgress = async (): Promise<void> => { | |||
| const { entropyProgress } = this.state | |||
| const entropyProgress = SKIP_ENTROPY_COLLECTION | |||
There was a problem hiding this comment.
I think its more efficient to move this to state init (line 39), if it has no other implications
There was a problem hiding this comment.
I wanted it to start out as 0 so that you have to at least touch the screen once to get to "100%" 😄
mnzaki
changed the title
|
NOTE: this will conflict with #1414 because of changes to |
|
I've been trying to look through and sort the conflicts, but I don't know if I have the right background knowledge - coming across duplicate |
|
This was harvested for some useful commits in the e2e tests branch, and the rest will come along in a later PR. |
Closes #1407
src/env.tsso they (and the code they guard inifstatements) can be easily eliminated by the minifier whenfalsebabel-plugin-transform-inline-environment-variablesto load theNODE_ENVvar and make env values based on it