Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update verifiable credential implementation to conform to v1.0 #393

Open
chunningham opened this issue Feb 26, 2020 · 2 comments
Open

Update verifiable credential implementation to conform to v1.0 #393

chunningham opened this issue Feb 26, 2020 · 2 comments

Comments

@chunningham
Copy link
Contributor

No description provided.

@PeterTheOne
Copy link

PeterTheOne commented Aug 14, 2020 •
edited
Loading

Let's collect what needs to change:

  • issued -> issuanceDate
  • claim -> credentialSubject

anything else?

PeterTheOne added a commit to PeterTheOne/jolocom-protocol-ts that referenced this issue Aug 24, 2020
@PeterTheOne
fix: update to vc-data-model v1.0
f5da46f 
issued -> issuanceDate
claim -> credentialSubject

jolocom/jolocom-lib#393
@PeterTheOne PeterTheOne mentioned this issue Aug 24, 2020
Open
@mnzaki
Copy link
Contributor

mnzaki commented Mar 5, 2021

As this will be a breaking change on the protocol level, basically breaking the lib's ability to read any previously issued credential, it either requires compatibility layer in the lib or we release a major version bump

PeterTheOne added a commit to PeterTheOne/jolocom-protocol-ts that referenced this issue Mar 14, 2021
@PeterTheOne
fix: update to vc-data-model v1.0
3ba70c6 
issued -> issuanceDate
claim -> credentialSubject

jolocom/jolocom-lib#393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PeterTheOne @mnzaki @chunningham