Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure integration tests #362

Open
Exulansis opened this issue Sep 19, 2019 · 1 comment
Open

Restructure integration tests #362

Exulansis opened this issue Sep 19, 2019 · 1 comment
Labels
tech debt Issues we need to address to make improve code quality
Milestone

Comments

@Exulansis
Copy link
Collaborator

Description

Currently the integration tests are slightly convoluted and difficult to maintain (i.e. we declare and use variables from the global scope, we rely on the order in which tests are executed in non transparent ways)

The tests can be into separate files for separate "suites", also all set-up / provisioning logic can be gathered in the in the provision.ts test file

Note: This issue was already addressed as part of the #327 (subsequently merged into 4.0-beta1). In order to simplify the review and feedback process, we decided it can be re-implemented (reusing existing code where possible) as a separate PR.

For reference purposes, please see cb40c6 and be0e35

@Exulansis
Copy link
Collaborator Author

Please check this notion document for additional context.

@Exulansis Exulansis added the tech debt Issues we need to address to make improve code quality label Sep 19, 2019
@Exulansis Exulansis added this to the 4.0 milestone Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Issues we need to address to make improve code quality
Projects
None yet
Development

No branches or pull requests

1 participant