Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup JolocomRegistry creation #356

Open
2 tasks
mnzaki opened this issue Sep 6, 2019 · 0 comments
Open
2 tasks

Cleanup JolocomRegistry creation #356

mnzaki opened this issue Sep 6, 2019 · 0 comments
Labels
tech debt Issues we need to address to make improve code quality

Comments

@mnzaki
Copy link
Contributor

mnzaki commented Sep 6, 2019

Description

In an effort to differentiate between the "jolocom method based registry" and the canonical jolocom registry, the createJolocomRegistry helper should return the canonical jolocom registry (no configurable anything). The logic inside createJolocomRegistry is construction logic that needs to go into the constructor

The registry class itself can get a name that better reflects that it is the "jolocom method based registry" and strictly for jolocom's own canonical registry, because JolocomRegistry is ambiguous

Part of #355

TODO

  • rename registry?
  • move out logic from createJolocomRegistry and make it non-configurable
@mnzaki mnzaki mentioned this issue Sep 6, 2019
6 tasks
@mnzaki mnzaki added the tech debt Issues we need to address to make improve code quality label Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Issues we need to address to make improve code quality
Projects
None yet
Development

No branches or pull requests

1 participant