You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Library consumers need to import certain interfaces and classes, they should not be using the direct paths or else we might break things if we make internal changes.
A definite "public" interface should be declared, specifying which interfaces are expected to be used publicly. Whether everything should be exported from ts/index.ts is still an open question. Perhaps some categorization?
Here are the imports from inside jolocom/smartwallet-app except for tests:
decide on which classes/functions should be exported under what path
re-export them from index file ([PR HERE])
create issue on jolocom/smartwallet-app about using the new exports
The text was updated successfully, but these errors were encountered:
mnzaki
changed the title
Export some classes/functions publicly directly from jolocom-lib
Export an explicitly public interface directly from 'jolocom-lib'
Sep 6, 2019
Another option is to consider the JolocomLib export our "public API" and just add whatever is missing to it. But types/interfaces will need to be exported, can't be added to the JolocomLib object
Description
Library consumers need to import certain interfaces and classes, they should not be using the direct paths or else we might break things if we make internal changes.
A definite "public" interface should be declared, specifying which interfaces are expected to be used publicly. Whether everything should be exported from
ts/index.ts
is still an open question. Perhaps some categorization?Here are the imports from inside jolocom/smartwallet-app except for tests:
And here are imports from tests:
Part of #355
TODO
The text was updated successfully, but these errors were encountered: