Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mutate input objects #315

Open
2 tasks
mnzaki opened this issue Jun 26, 2019 · 1 comment
Open
2 tasks

Don't mutate input objects #315

mnzaki opened this issue Jun 26, 2019 · 1 comment
Labels
breaking change bug Something isn't working tech debt Issues we need to address to make improve code quality

Comments

@mnzaki
Copy link
Contributor

mnzaki commented Jun 26, 2019 •
edited
Loading

Description

The library sometimes mutates input objects, for example in identityWallet.create.signedCredential, the claim object gets an id field added to it (which contains the DID)

Part of #355

BREAKING CHANGE: some code might depend on the behavior??

TODO

  • look for other instances
  • PR
@mnzaki mnzaki mentioned this issue Sep 6, 2019
Open
6 tasks
@mnzaki mnzaki added breaking change bug Something isn't working tech debt Issues we need to address to make improve code quality labels Sep 6, 2019
@mnzaki
Copy link
Contributor Author

mnzaki commented Sep 6, 2019

NOTE: this is an old report and needs to be reconfirmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change bug Something isn't working tech debt Issues we need to address to make improve code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mnzaki