fix: --context option ignored when another option presence (#593) #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheoD02
force-pushed
the
fix/issue-593
branch
from
826ee4e to
205bb8b
Compare
|
Thanks a lot for your issue and this fix 💛 I can't yet think of a better fix for now. But I'm not sure we should merge it in this state so I would prefer to wait others' feedback for now or if someone have another idea to tackle this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey
An attempt to fix #593 I'm not huge fan of the current implementation but it a working one.
Can you give me more feedback about how we can do a better implementation ?