Support for different custom build configurations #83
Conversation
Added DEBUG flags for HotReloading and HotReloadingGuts modules
|
Hi again, thanks for filing the report and this PR. I filed something too and I'll add your FB number. Your proposed PR is exactly what I tried when I said "there were other problems" which I have since fixed because the C header files are not compiled for the module export to Swift with -DDEBUG even with your change which a separate Xcode bug. I'm going to have to decline this PR was I don't really want to force a debug build if the user is building for release (which they should never be doing with HotReloading configured anyway). What caused this problem is this recent commit where I was trying to ensure people never release with HotReloading active. I may back it out as due to the problem we found all the commit does is break HotReloading for some people using other configuration names. Releasing with HotReloading configured should only bloat your app package a little and attempt a random local area network connection then give up. It is already mentioned a coupe of times in the READMEs you should never release with the HotReloading Swift Package configured which is the important thing. I need to think about this some more. As things stand it errs on the side of caution which is a good thing. I trying to encourage most people to use the pre-built bundles if they are not injecting on a device anyway. This leaves people injecting on a device with a non-Debug config name which should be a fairly small number of people to inconvenience but it is better than leaving open the possibility of shipping active HotReloading code with their app even if that would normally not be a problem. |
|
Oh, I see your intentions. You want to make sure it's okay to include it in the release build. That's great. Thanks! |
Description
I reported an issue last week, and it turns out that SPM is missing builds when the "Custom Build Configuration" (such as Test) only exists in the main app.
There have been a lot of reports about this.
As SPM does not support custom build configurations, only the configurations that contain "debug" in their names make the Xcode builder put the DEBUG flag in the build options.
I reported it through Feedback Assistant (FB12343218) and now waiting for its response.
HotReloading module should be removed from the release build anyway,
What about putting DEBUG flag in the overall flags?
Could you please check these changes?
Fixes #82 issue
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Using SwiftUI-Kit,
I tested it with multiple schemes and multiple build configurations, and everything worked fine.
I checked on the Device and it was fine.