Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should commitizen be opt-in? #22

Closed
joematthews opened this issue Mar 2, 2024 · 2 comments
Closed

Should commitizen be opt-in? #22

joematthews opened this issue Mar 2, 2024 · 2 comments
Labels
question Further information is requested

Comments

@joematthews
Copy link
Owner

joematthews commented Mar 2, 2024

I think commitizen is great for individuals and teams that want to acquaint themselves with convention commits.

In exteme-angular you can omit the message of a commit (git commit) and commitizen will prompt with a interactive CUI guiding you thru how to create a conventional commit.

However, when committed with a well formed convention commit message, The user can use CTRL-C to skip commitizen and use the commit message (but this is not communicated in the prompt at all. Also commitizen does not report the commit message after completing the prompts.

I do see value in commitizen, but should should it be disabled by default, or removed, in favor of clarity and then rely solely on commitlint to report missing convention commit message components?

@joematthews joematthews added the question Further information is requested label Mar 2, 2024
@replete
Copy link
Contributor

replete commented Jan 12, 2025

Just to chip in on this, it's very nice but is yet another dependency I might avoid in a big org and rather enforce good commits in PR review processes. I did like the experience of the popup in github desktop when I tried to commit something with a capital letter in it, but its yet another piece of software in the stack - but again this might be vital in some orgs. Maybe non default is better?

@joematthews
Copy link
Owner Author

Thank you for the feedback on this! I think I will keep commitlint for now, but commitizen has never really sat well with me and will likely be removed from the next release. Closing this issue out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants