Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trial period check in Google Play doesn't work #33

Open
catacs opened this issue Jan 15, 2019 · 2 comments
Open

Trial period check in Google Play doesn't work #33

catacs opened this issue Jan 15, 2019 · 2 comments
Assignees
Labels

Comments

@catacs
Copy link

catacs commented Jan 15, 2019

When I try to call trial? method from CandyCheck::PlayStore::Subscription class i get false when a subscription is trial. Checking the google play documentation, the added a new payment_state with value 2 which is trial.

https://developers.google.com/android-publisher/api-ref/purchases/subscriptions

paymentState | integer | The payment state of the subscription. Possible values are:

  1. Payment pending
  2. Payment received
  3. Free trial
@jnbt
Copy link
Owner

jnbt commented May 11, 2020

This is a good point, we should allow also the value 2

@jnbt jnbt self-assigned this May 11, 2020
@jnbt jnbt added the bug label May 11, 2020
@jnbt
Copy link
Owner

jnbt commented May 31, 2021

@christophweegen Can you please have a look here. I think we need to whitelist the value 2 on CandyCheck::PlayStore::Subscription#trail?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants