Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check problem size limitations for all algorithms #32

Open
jmyrberg opened this issue Aug 7, 2022 · 3 comments
Open

Check problem size limitations for all algorithms #32

jmyrberg opened this issue Aug 7, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@jmyrberg
Copy link
Owner

jmyrberg commented Aug 7, 2022

Ensure correct errors are thrown regarding problem size limitations before trying to solve it within Fortran

@jmyrberg jmyrberg added the enhancement New feature or request label Aug 7, 2022
@Theelx
Copy link

Theelx commented Sep 12, 2023

It would be nice if it were possible to increase the limits slightly, at least for the "mtm" method for multiple knapsack. Finding a solution with 10 knapsacks and 85 items and profits of 1 took ~1.1 seconds to solve 1000 times (I placed it in a loop to better eliminate noise). Later on, I will likely need ~15-20 knapsacks, and it seems impossible to change the limit without forking and changing both the Fortran and Python.

Would it be reasonable to allow users to use up to 20-25 knapsacks, but display a warning to stdout (on by default but disabled if the user passes warnings=False) in case the user needs more than 10 knapsacks?

@jmyrberg
Copy link
Owner Author

It would be nice if it were possible to increase the limits slightly, at least for the "mtm" method for multiple knapsack. Finding a solution with 10 knapsacks and 85 items and profits of 1 took ~1.1 seconds to solve 1000 times (I placed it in a loop to better eliminate noise). Later on, I will likely need ~15-20 knapsacks, and it seems impossible to change the limit without forking and changing both the Fortran and Python.

Would it be reasonable to allow users to use up to 20-25 knapsacks, but display a warning to stdout (on by default but disabled if the user passes warnings=False) in case the user needs more than 10 knapsacks?

I have no objections in increasing the limits. However, if I remember correctly, I actually tried it, but it wasn’t as easy as I thought on the Fortran side, and thus left the code as-is. If you’re willing to have a go on this, feel free to fork and make a PR 🙂

@Theelx
Copy link

Theelx commented Sep 26, 2023

#51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants