Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nimble Picker emojis are not displayed #41

Open
RichPC opened this issue Nov 22, 2018 · 4 comments
Open

Nimble Picker emojis are not displayed #41

RichPC opened this issue Nov 22, 2018 · 4 comments

Comments

@RichPC
Copy link

RichPC commented Nov 22, 2018

Hi, I've just started using emoji-mart-vue 2.6.5 and vue 2.5.17 with chromium 70

The picker component with messenger set works, but the nimble picker doesn't show any emoji images, am I doing something wrong?

Nimble Picker
<nimble-picker
  :data="data"
  set="messenger"
/>

Picker
<picker
  set="messenger"
/>

`
import data from 'emoji-mart-vue/data/messenger.json'
import { Picker, NimblePicker } from 'emoji-mart-vue'

export default {
components: {
Picker,
NimblePicker,
},
data() {
return {
data: data
}
}
}
`

images_missing_screenshot

I can't see any sign of errors in the devtools console

@bribar
Copy link

bribar commented Jan 17, 2019

@RichPC I get something similar, but mine throws category errors...and nothing appears in picker

screen shot 2019-01-17 at 9 57 03 am

<nimble-picker set="apple" :data="data" @select="addReaction" title="Pick your emoji…" emoji="point_up" color="#26cdf9"/>

import data from 'emoji-mart-vue/data/apple.json'
import { NimblePicker } from 'emoji-mart-vue'

data () { return { data: data } }

components: { 'nimble-picker' : NimblePicker }

"emoji-mart-vue": "^2.6.6"

@jm-david anything on a fix for this? Using the normal picker works, but I would like to optimize and only load what I need...

@lucascorrea97
Copy link

lucascorrea97 commented Jan 22, 2019

Any updates on that? I'm having the same issue

@serebrov
Copy link

serebrov commented Feb 6, 2019

Looks like this issue is because the uncompress method (https://github.com/jm-david/emoji-mart-vue/blob/master/src/utils/data.js#L79) does not return data back, it just modifies it in place.

But in the places where uncompress is used, it is expected to return the value, for example (https://github.com/jm-david/emoji-mart-vue/blob/master/src/components/picker/nimblePicker.vue#L140):

return {
      mutableData: this.data.compressed ? uncompress(this.data) : this.data,
      ...
    }

So after this statement, the mutableData property is undefined and the error is raised in the created() method (https://github.com/jm-david/emoji-mart-vue/blob/master/src/components/picker/nimblePicker.vue#L198) when we access the this.mutableData.categories.

Not sure though why it works with Picker component, probably the data is being uncompressed somewhere, but I don't see where exactly.

@serebrov
Copy link

serebrov commented Feb 9, 2019

Related issue: #48, related PRs: #49 and #45

peterchappell pushed a commit to peterchappell/emoji-mart-vue that referenced this issue Jul 23, 2019
peterchappell pushed a commit to peterchappell/emoji-mart-vue that referenced this issue Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants