Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question] PR process #14

Open
Arsakes opened this issue Oct 19, 2021 · 2 comments · May be fixed by #15
Open

[Question] PR process #14

Arsakes opened this issue Oct 19, 2021 · 2 comments · May be fixed by #15
Assignees
@phantastra
Labels
external contribution contribution by someone not on the team

Comments

@Arsakes
Copy link

Arsakes commented Oct 19, 2021 •
edited
Loading

I have a set of changes to Atmora that flesh out the gameplay in area.
Am I free to make a pull request? Is there even anyone who can review it and merge it with nonzero chance or the whole effort goes toward EK2 now?

Changes so far:

  • Decision to find a stable sea route to Tammriel (makes mage guild & companions available to Atmoran rulers and lifts some other constraints)
  • Decision to form a trade company based in Atmora (merchant republic title) along with localisation & flags.
  • Fixes to combat spells
  • Introduction of dragon priest graphics
@phantastra
Copy link
Collaborator

Hi, I'm glad someone is interested in contributing to EK1! I'd be happy to review it when I have the chance, please feel free to make a pull request.

@Arsakes
Copy link
Author

Arsakes commented Oct 22, 2021

Should I have fork or custom branch here?

@TheynT TheynT linked a pull request Oct 26, 2021 that will close this issue
Atmora #15
Open
@TheynT TheynT assigned TheynT and phantastra and unassigned TheynT Oct 26, 2021
@TheynT TheynT added the external contribution contribution by someone not on the team label Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phantastra phantastra

Labels
external contribution contribution by someone not on the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Atmora Arsakes/elder-kings-ck2
3 participants
@Arsakes @phantastra @TheynT