feat(moderator): Skips redirect events when moving to main from breakout. #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damencho
force-pushed
the
skip-redirect-on-breakout-move-to-main
branch
from
70628b6
to
b796120
Compare
damencho
force-pushed
the
skip-redirect-on-breakout-move-to-main
branch
from
b796120
to
7224491
Compare
hristoterezov
approved these changes
Sep 20, 2024
Romick2005
reviewed
Sep 24, 2024
| this.room.xmpp.moderator.sendConferenceRequest(this.room.roomjid).finally(resolve); | ||
| this.room.xmpp.moderator.sendConferenceRequest(this.room.roomjid) | ||
| .catch(e => logger.trace('sendConferenceRequest rejected', e)) | ||
| .finally(resolve); |
There was a problem hiding this comment.
Why do you need finally here? Isn't it better to have just then?
Romick2005
reviewed
Sep 24, 2024
| @@ -239,6 +239,9 @@ export default class ChatRoom extends Listenable { | |||
| const preJoin | |||
| = this.options.disableFocus | |||
| ? Promise.resolve() | |||
| .finally(() => { | |||
There was a problem hiding this comment.
Same here: Why do you need finally here? Isn't it better to have just then?
Romick2005
reviewed
Sep 24, 2024
| }); | ||
| } | ||
| }).then(() => { | ||
| this.conferenceRequestSent = true; | ||
| }) | ||
| .finally(() => { |
There was a problem hiding this comment.
Would be great if you could add catch -> log some error and then add then to proceed with this. In general I would suggest to avoid using finally as mush as possible as it does not work right away in RN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.