Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ashley ioc does not work with create-react-app build #1

Open
asemoon opened this issue Jul 5, 2018 · 1 comment
Open

Ashley ioc does not work with create-react-app build #1

asemoon opened this issue Jul 5, 2018 · 1 comment

Comments

@asemoon
Copy link

asemoon commented Jul 5, 2018

I am using Ashley as the ioc container for a react app I am coding and everything works as expected. Except when I try to build a production version of the app I get the following error:
Creating an optimized production build... Failed to compile. Failed to minify the code from this file: ./node_modules/ashley/src/errors.js:3

Would it be possible for Ashley to be precompiled per following react instructions?
https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#npm-run-build-fails-to-minify

@jiripospisil
Copy link
Owner

Sure, why not. I can see you're already working on it in your branch. PRs are always appreciated :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants