Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dense pdf417 codes are not recognized #61

Open
dustin-graham opened this issue Jan 25, 2022 · 0 comments
Open

dense pdf417 codes are not recognized #61

dustin-graham opened this issue Jan 25, 2022 · 0 comments
Assignees

Comments

@dustin-graham
Copy link
Collaborator

while attempting to scan the back of my drivers license using the develop branch I discovered that the pdf417 code on my card was not being recognized on Android. I switched back to the main branch to test and found that it scanned it easily. Doing a quick analysis of the native code differences and I discovered a difference in how the preview and analysis image sources are configured. On the main branch they are configured identically, but on the develop, the analysis image does not specify a specific target resolution like the preview image does. I corrected this behavior and discovered that my license pdf417 code can now be scanned. I believe what is happening is that under the hood the analysis image is skewed slightly. I think this ends up being ok for lots of codes like QR and code128 but caused the pdf417 on my license card to be unrecognized.

We need to adjust the analysis image size so that it will recognize all codes that it can see.

@dustin-graham dustin-graham self-assigned this Jan 25, 2022
dustin-graham added a commit to gojitsucom/fast_barcode_scanner that referenced this issue Jan 25, 2022
The analysis image was being skewed which caused dense code formats
like pdf417 to not be read consistently.
dustin-graham added a commit to gojitsucom/fast_barcode_scanner that referenced this issue Feb 4, 2022
dustin-graham added a commit that referenced this issue Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant