Skip to content

Commit c0ed12c

Browse files
committed
Remove references to FlutterActivity
1 parent 24f5bb9 commit c0ed12c

File tree

4 files changed

+33
-23
lines changed

4 files changed

+33
-23
lines changed

fast_barcode_scanner/CHANGELOG.md

+18-13
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,34 @@
1+
## 1.1.3
2+
3+
- Remove references to FlutterActivity (required by local_auth package)
4+
15
## 1.1.2
26

3-
* Fixed a bug where the app would crash when denying permissions on iOS.
4-
* Smaller code cleanups
5-
* Updated CameraX and ML Kit to latest versions.
7+
- Fixed a bug where the app would crash when denying permissions on iOS.
8+
- Smaller code cleanups
9+
- Updated CameraX and ML Kit to latest versions.
610

711
## 1.1.1
812

9-
* Camera position now taken into account on Android.
10-
* Fix DetectionMode.pauseDetection on Android.
11-
* Updated CameraX to v1.1.0-alpha05
13+
- Camera position now taken into account on Android.
14+
- Fix DetectionMode.pauseDetection on Android.
15+
- Updated CameraX to v1.1.0-alpha05
1216

1317
## 1.1.0
14-
* Relaxed kotlin version to 1.3.50
15-
* Updated MLKit version (16.1.2)
16-
* The camera state now contains the torch state (on/off)
17-
* Fixed toggling the torch in the example project
18+
19+
- Relaxed kotlin version to 1.3.50
20+
- Updated MLKit version (16.1.2)
21+
- The camera state now contains the torch state (on/off)
22+
- Fixed toggling the torch in the example project
1823

1924
## 1.0.2
2025

21-
* Even more documentation.
26+
- Even more documentation.
2227

2328
## 1.0.1
2429

25-
* Updated documentation.
30+
- Updated documentation.
2631

2732
## 1.0.0
2833

29-
* Initial pre-release.
34+
- Initial pre-release.

fast_barcode_scanner/android/src/main/kotlin/com/jhoogstraat/fast_barcode_scanner/BarcodeReader.kt

+11-5
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
11
package com.jhoogstraat.fast_barcode_scanner
22

33
import android.Manifest
4+
import android.app.Activity
45
import android.content.pm.PackageManager
56
import android.util.Log
67
import android.view.Surface
78
import androidx.camera.core.*
89
import androidx.camera.lifecycle.ProcessCameraProvider
10+
import androidx.core.app.ActivityCompat
911
import androidx.core.content.ContextCompat
1012
import androidx.core.util.Consumer
13+
import androidx.lifecycle.LifecycleOwner
1114
import com.google.android.gms.tasks.OnFailureListener
1215
import com.google.android.gms.tasks.OnSuccessListener
1316
import com.google.mlkit.vision.barcode.Barcode
1417
import com.google.mlkit.vision.barcode.BarcodeScannerOptions
15-
import io.flutter.embedding.android.FlutterActivity
1618

1719
import io.flutter.plugin.common.MethodChannel.Result
1820
import io.flutter.plugin.common.PluginRegistry.RequestPermissionsResultListener
@@ -25,7 +27,7 @@ data class CameraConfig(val formats: IntArray, val mode: DetectionMode, val reso
2527

2628
class BarcodeReader(private val flutterTextureEntry: TextureRegistry.SurfaceTextureEntry, private val listener: (List<Barcode>) -> Unit) : RequestPermissionsResultListener {
2729
/* Android Lifecycle */
28-
private var activity: FlutterActivity? = null
30+
private var activity: Activity? = null
2931

3032
/* Camera */
3133
private lateinit var camera: Camera
@@ -42,7 +44,7 @@ class BarcodeReader(private val flutterTextureEntry: TextureRegistry.SurfaceText
4244
private var isInitialized = false
4345
private var pauseDetection = false
4446

45-
fun attachToActivity(activity: FlutterActivity) {
47+
fun attachToActivity(activity: Activity) {
4648
this.activity = activity
4749
}
4850

@@ -74,7 +76,11 @@ class BarcodeReader(private val flutterTextureEntry: TextureRegistry.SurfaceText
7476
if (allPermissionsGranted()) {
7577
initCamera()
7678
} else {
77-
activity?.requestPermissions(REQUIRED_PERMISSIONS, REQUEST_CODE_PERMISSIONS)
79+
ActivityCompat.requestPermissions(
80+
activity!!,
81+
REQUIRED_PERMISSIONS,
82+
REQUEST_CODE_PERMISSIONS
83+
)
7884
}
7985

8086
result.success(hashMapOf("textureId" to flutterTextureEntry.id(), "surfaceOrientation" to 0, "surfaceHeight" to 1280, "surfaceWidth" to 720))
@@ -192,7 +198,7 @@ class BarcodeReader(private val flutterTextureEntry: TextureRegistry.SurfaceText
192198
preview.setSurfaceProvider(cameraExecutor, cameraSurfaceProvider)
193199

194200
// Bind camera to Lifecycle
195-
camera = cameraProvider.bindToLifecycle(activity!!, cameraSelector, preview, imageAnalyzer)
201+
camera = cameraProvider.bindToLifecycle(activity!! as LifecycleOwner, cameraSelector, preview, imageAnalyzer)
196202

197203
// Make sure detections are allowed
198204
pauseDetection = false

fast_barcode_scanner/android/src/main/kotlin/com/jhoogstraat/fast_barcode_scanner/FastBarcodeScannerPlugin.kt

+1-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package com.jhoogstraat.fast_barcode_scanner
22

33

44
import androidx.annotation.NonNull
5-
import io.flutter.embedding.android.FlutterActivity
65

76
import io.flutter.embedding.engine.plugins.FlutterPlugin
87
import io.flutter.embedding.engine.plugins.activity.ActivityAware
@@ -33,7 +32,7 @@ class FastBarcodeScannerPlugin: FlutterPlugin, MethodCallHandler, ActivityAware
3332
// https://flutter.dev/docs/development/packages-and-plugins/plugin-api-migration#uiactivity-plugin
3433
// https://github.com/flutter/plugins/blob/master/packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java
3534
override fun onAttachedToActivity(binding: ActivityPluginBinding) {
36-
reader.attachToActivity(binding.activity as FlutterActivity)
35+
reader.attachToActivity(binding.activity)
3736
binding.addRequestPermissionsResultListener(reader)
3837
channel.setMethodCallHandler(this)
3938
}

fast_barcode_scanner/pubspec.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
name: fast_barcode_scanner
22
description: A fast barcode scanner using MLKit on Android and AVFoundation on iOS.
3-
version: 1.1.2
3+
version: 1.1.3
44
homepage: https://github.com/jhoogstraat/fast_barcode_scanner
55
repository: https://github.com/jhoogstraat/fast_barcode_scanner
66

77
environment:
8-
sdk: '>=2.12.0 <3.0.0'
8+
sdk: ">=2.12.0 <3.0.0"
99
flutter: ">=2.0.0"
1010

1111
dependencies:
@@ -25,4 +25,4 @@ flutter:
2525
package: com.jhoogstraat.fast_barcode_scanner
2626
pluginClass: FastBarcodeScannerPlugin
2727
ios:
28-
pluginClass: FastBarcodeScannerPlugin
28+
pluginClass: FastBarcodeScannerPlugin

0 commit comments

Comments
 (0)