Skip to content
This repository was archived by the owner on Dec 30, 2019. It is now read-only.

Commit 0b34dea

Browse files
committed
housekeeping
1 parent 1f4ad87 commit 0b34dea

File tree

5 files changed

+32
-6
lines changed

5 files changed

+32
-6
lines changed

Makefile

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,16 @@
1-
CLASSPATH := lib/spark.jar:lib/commons-io-2.4.jar:lib/scala-library-2.10.4.jar
1+
BASE_CLASSPATH := lib/spark.jar
2+
BUILD_CLASSPATH := $(BASE_CLASSPATH)
3+
#BUILD_CLASSPATH := $(BUILD_CLASSPATH):lib/scala-library-2.10.4.jar
4+
RUNTIME_CLASSPATH := conf:$(BASE_CLASSPATH):spock.jar
25

36
check: spock.jar
4-
CLASSPATH=$(CLASSPATH) julia test/runtests.jl
7+
CLASSPATH=$(RUNTIME_CLASSPATH) julia test/runtests.jl
58

69
spock.jar: $(shell find src/ -name \*.java)
7-
javac -cp $(CLASSPATH) $^
8-
cd src && find . -name \*.class -print0 | xargs -0 jar cf ../$@
10+
mkdir -p bin
11+
javac -Xlint -d bin -cp $(BUILD_CLASSPATH) $^
12+
jar cf spock.jar -C bin .
13+
14+
.PHONY: clean
15+
clean:
16+
rm -rf bin spock.jar

conf/log4j.properties

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# Set everything to be logged to the console
2+
log4j.rootCategory=WARN, console
3+
log4j.appender.console=org.apache.log4j.ConsoleAppender
4+
log4j.appender.console.target=System.err
5+
log4j.appender.console.layout=org.apache.log4j.PatternLayout
6+
log4j.appender.console.layout.ConversionPattern=%d{yy/MM/dd HH:mm:ss} %p %c{1}: %m%n
7+
8+
# Settings to quiet third party logs that are too verbose
9+
log4j.logger.org.eclipse.jetty=WARN
10+
log4j.logger.org.eclipse.jetty.util.component.AbstractLifeCycle=ERROR
11+
log4j.logger.org.apache.spark.repl.SparkIMain$exprTyper=INFO
12+
log4j.logger.org.apache.spark.repl.SparkILoop$SparkILoopInterpreter=INFO

src/Spock.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ module Spock
77
export SparkContext, RDD, parallelize
88

99
const classpath = get(ENV, "CLASSPATH", "")
10-
JavaCall.init(["-ea", "-Xmx1024M", "-Djava.class.path=spock.jar:$(classpath)"])
10+
JavaCall.init(["-ea", "-Xmx1024M", "-Djava.class.path=$(classpath)"])
1111

1212
JClass = @jimport java.lang.Class
1313
JArrays = @jimport java.util.Arrays
@@ -26,7 +26,7 @@ module Spock
2626
jsc::JJavaSparkContext
2727
end
2828

29-
function SparkContext(master::String="local", appname::String="Julia Spock App @ $(spockid())")
29+
function SparkContext(master::String="local", appname::String="Julia Spock app @ $(spockid())")
3030
SparkContext(JJavaSparkContext((JString, JString), master, appname))
3131
end
3232

src/edu/berkeley/cs/amplab/spock/JuliaFunction.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import java.util.Random;
2020

2121
public class JuliaFunction implements FlatMapFunction<Iterator<JuliaObject>, JuliaObject> {
22+
private static final long serialVersionUID = 1;
2223
final JuliaObject func;
2324

2425
public JuliaFunction(JuliaObject func) {

src/edu/berkeley/cs/amplab/spock/JuliaObject.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,23 @@
55
import java.io.Serializable;
66

77
class SpockException extends Exception {
8+
private static final long serialVersionUID = 1;
9+
810
public SpockException(JuliaObject exc) {
911
throw new RuntimeException("SpockException");
1012
}
1113
}
1214

1315
class JuliaException extends SpockException {
16+
private static final long serialVersionUID = 1;
17+
1418
public JuliaException(JuliaObject exc) {
1519
super(exc);
1620
}
1721
}
1822

1923
public class JuliaObject implements Serializable {
24+
private static final long serialVersionUID = 1;
2025
byte[] payload;
2126

2227
public JuliaObject(byte[] serializedPayload) {

0 commit comments

Comments
 (0)