Concurrent compilation when watching

[dapetcu21]

When watching, if files change very fast, roots watch will start compiling twice, concurrently. Nothing bad usually happens, but I can see how this would lead to a race condition (plus, it doesn't look nice and it's additional strain to the CPU).

A solution would be to queue up a second compile if a file changed while compilation was already happening.

➜  argo-tabs git:(master) ✗ roots3 watch
compiling... done!
compiling... compiling... compiling... compiling... done!
done!
done!
done!
compiling... compiling... done!
done!
compiling... compiling... done!
done!

[jescalan]

Good call, will make this happen.

[samccone]

wow such async

[jescalan]

So just thinking about this, wouldn't it even be better to just stop the first compile and move to the second? Who cares if public is a little out of whack, it's going to be recompiled in a moment anyway. This would have to not be the case if we were to re-implement selective compilation (try to compile one file if possible rather than the whole project), but for now we are recompiling all...

[samccone]

I am running into this exact issue still on v3... I think this is prob blocking right?

[jescalan]

This is something we want to fix before release. It just means a bit of queueing in watch mode. If anyone wants to jump in and help with implementation it would be awesome, I have my hands full at the moment but will get to this eventually if not.

[samccone]

was there ever any thoughts on the root of this problem?

[jescalan]

Yeah, the root is that if you compile twice, it runs twice. There is no mechanism in place to queue compiles right now. It's not really that it's a bug with a solution, it's more of a feature that hasn't been implemented yet.

[samccone]

sometimes this can end poorly

[jescalan]

Yup, that's why we have an open issue for it...

[samccone]

yep :) ha just leaving another note for me