Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date-time type DTSTART without DTEND, but have DURATION #304

Closed
eouia opened this issue Feb 16, 2024 · 7 comments
Closed

date-time type DTSTART without DTEND, but have DURATION #304

eouia opened this issue Feb 16, 2024 · 7 comments

Comments

@eouia
Copy link

eouia commented Feb 16, 2024

Sorry for revamping the old topic. This is related to #90

For cases where a "VEVENT" calendar component specifies a "DTSTART" property with a DATE-TIME value type but no "DTEND" property, the event ends on the same calendar date and time of day specified by the "DTSTART" property.

I understand that only DTSTART without DTEND should be regarded as a momentary event.
But how about with date-time type DTSTART and DURATION without DTEND?

In actual practice, Synology CalDAV provides that kind of VEVENTS, so node-ical cannot parse it correctly.

BEGIN:VCALENDAR
PRODID:-//Synology//EN
VERSION:2.0
BEGIN:VEVENT
CREATED:20240215T101655
LAST-MODIFIED:20240215T101655
DTSTAMP:20240215T101655
UID:[email protected]
SEQUENCE:2
SUMMARY:period test2
TRANSP:OPAQUE
DESCRIPTION:
LOCATION:Kriftel
X-APPLE-STRUCTURED-LOCATION;VALUE=URI;X-TITLE=Kriftel: geo:50.083558\,8.4693855
DTSTART:20240215T090000Z
DURATION:PT15M
END:VEVENT
END:VCALENDAR

If DURATION has meaning only on date type DTSTART, Why does the spec have H, M, and S options?

@sdetweil
Copy link
Contributor

duration can support both date and date time

the spec says

Screenshot_20240216_103439_Chrome

DTEND does NOT say mandatory
Screenshot_20240216_103841_Chrome

@eouia
Copy link
Author

eouia commented Feb 16, 2024

node-iCal seems that cannot handle this kind(DTSTART and DURATION but not DTEND) Can it?

@sdetweil
Copy link
Contributor

sdetweil commented Feb 16, 2024

I put in code 3 years ago for this when I fixed missing DTEND . and I think there was a testcase for that

#96

edit: testcsse did not cover not DTEND/but duration

@eouia
Copy link
Author

eouia commented Feb 20, 2024

@sdetweil So... Is it a kind of thing to fix? Or Did I miss something to use?

@sdetweil
Copy link
Contributor

I will try to test later today.

@sdetweil
Copy link
Contributor

this handler is broken.
I will submit a PR and testcases for date-time and full date
with and without duration

@sdetweil
Copy link
Contributor

I submitted pr #306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants