From 08fc4b7d55893a2c6e16580079aefd736711e317 Mon Sep 17 00:00:00 2001 From: Janhvi Harwani Date: Tue, 21 May 2024 12:18:38 -0700 Subject: [PATCH 01/11] Added alt attribute to all img tag --- .github/config.yml | 2 +- .../hudson/diagnosis/MemoryUsageMonitor/index.jelly | 2 +- .../hudson/model/DirectoryBrowserSupport/dir.jelly | 8 ++++---- core/src/main/resources/jenkins/model/Jenkins/_404.jelly | 2 +- .../resources/jenkins/model/Jenkins/_404_simple.jelly | 2 +- core/src/main/resources/jenkins/model/Jenkins/oops.jelly | 2 +- core/src/main/resources/lib/hudson/executors.jelly | 2 +- core/src/main/resources/lib/layout/dropdowns/custom.jelly | 2 +- 8 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/config.yml b/.github/config.yml index dd9685382145..a0542b426f96 100644 --- a/.github/config.yml +++ b/.github/config.yml @@ -20,6 +20,6 @@ firstPRMergeComment: > - + jenkins welcome page diff --git a/core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly b/core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly index bb0efd378ea8..3cde806bfbf8 100644 --- a/core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly +++ b/core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly @@ -61,7 +61,7 @@ THE SOFTWARE. - + diff --git a/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly b/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly index a50dd9b46cf9..dfafb0f734b8 100644 --- a/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly +++ b/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly @@ -50,13 +50,13 @@ THE SOFTWARE. ${%No files in directory}

- + ${%Symlinks are hidden}

- + ${%Tmp directories are hidden}

@@ -124,13 +124,13 @@ THE SOFTWARE.

- + warning image ${%Symlinks are hidden}

- + warning image ${%Tmp directories are hidden}

diff --git a/core/src/main/resources/jenkins/model/Jenkins/_404.jelly b/core/src/main/resources/jenkins/model/Jenkins/_404.jelly index 4605b5926760..d7433188a87f 100644 --- a/core/src/main/resources/jenkins/model/Jenkins/_404.jelly +++ b/core/src/main/resources/jenkins/model/Jenkins/_404.jelly @@ -34,7 +34,7 @@ THE SOFTWARE.

- + ${%Oops!}

diff --git a/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly b/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly index c6a876bb2955..520dd8482b00 100644 --- a/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly +++ b/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly @@ -48,7 +48,7 @@ THE SOFTWARE.

- + ${%Oops!}

diff --git a/core/src/main/resources/jenkins/model/Jenkins/oops.jelly b/core/src/main/resources/jenkins/model/Jenkins/oops.jelly index 28238c660253..fabdd175cbcb 100644 --- a/core/src/main/resources/jenkins/model/Jenkins/oops.jelly +++ b/core/src/main/resources/jenkins/model/Jenkins/oops.jelly @@ -32,7 +32,7 @@ THE SOFTWARE.

- ${%Oops!} + ${%Oops!}

${%problemHappened}

diff --git a/core/src/main/resources/lib/hudson/executors.jelly b/core/src/main/resources/lib/hudson/executors.jelly index ce01688e2ee6..d34a0a3c0595 100644 --- a/core/src/main/resources/lib/hudson/executors.jelly +++ b/core/src/main/resources/lib/hudson/executors.jelly @@ -41,7 +41,7 @@ THE SOFTWARE. - ( ${%offline}) + (error image ${%offline}) (${%launching}) diff --git a/core/src/main/resources/lib/layout/dropdowns/custom.jelly b/core/src/main/resources/lib/layout/dropdowns/custom.jelly index 4b9d18fc59b6..b563f95b74cd 100644 --- a/core/src/main/resources/lib/layout/dropdowns/custom.jelly +++ b/core/src/main/resources/lib/layout/dropdowns/custom.jelly @@ -31,7 +31,7 @@ THE SOFTWARE. - + ]]> From 4a2c9102bec0cf82765c84a05476656cd623f194 Mon Sep 17 00:00:00 2001 From: Janhvi Harwani Date: Tue, 21 May 2024 12:42:30 -0700 Subject: [PATCH 02/11] Added null as text in alt attribute --- .../resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly | 2 +- .../resources/hudson/model/DirectoryBrowserSupport/dir.jelly | 4 ++-- core/src/main/resources/jenkins/model/Jenkins/_404.jelly | 2 +- .../main/resources/jenkins/model/Jenkins/_404_simple.jelly | 2 +- core/src/main/resources/jenkins/model/Jenkins/oops.jelly | 2 +- core/src/main/resources/lib/layout/dropdowns/custom.jelly | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly b/core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly index 3cde806bfbf8..b2c710068e04 100644 --- a/core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly +++ b/core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly @@ -61,7 +61,7 @@ THE SOFTWARE.
- + null diff --git a/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly b/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly index dfafb0f734b8..6760625b676c 100644 --- a/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly +++ b/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly @@ -50,13 +50,13 @@ THE SOFTWARE. ${%No files in directory}

- + null ${%Symlinks are hidden}

- + null ${%Tmp directories are hidden}

diff --git a/core/src/main/resources/jenkins/model/Jenkins/_404.jelly b/core/src/main/resources/jenkins/model/Jenkins/_404.jelly index d7433188a87f..f4e1d8cc2230 100644 --- a/core/src/main/resources/jenkins/model/Jenkins/_404.jelly +++ b/core/src/main/resources/jenkins/model/Jenkins/_404.jelly @@ -34,7 +34,7 @@ THE SOFTWARE.

- + null ${%Oops!}

diff --git a/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly b/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly index 520dd8482b00..55033cec0c15 100644 --- a/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly +++ b/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly @@ -48,7 +48,7 @@ THE SOFTWARE.

- + null ${%Oops!}

diff --git a/core/src/main/resources/jenkins/model/Jenkins/oops.jelly b/core/src/main/resources/jenkins/model/Jenkins/oops.jelly index fabdd175cbcb..4de7d295fa4f 100644 --- a/core/src/main/resources/jenkins/model/Jenkins/oops.jelly +++ b/core/src/main/resources/jenkins/model/Jenkins/oops.jelly @@ -32,7 +32,7 @@ THE SOFTWARE.

- ${%Oops!} + null ${%Oops!}

${%problemHappened}

diff --git a/core/src/main/resources/lib/layout/dropdowns/custom.jelly b/core/src/main/resources/lib/layout/dropdowns/custom.jelly index b563f95b74cd..d93ef656329e 100644 --- a/core/src/main/resources/lib/layout/dropdowns/custom.jelly +++ b/core/src/main/resources/lib/layout/dropdowns/custom.jelly @@ -31,7 +31,7 @@ THE SOFTWARE. - + null ]]> From 4d8fd426116664abdb7d45af29ba2e226821b76d Mon Sep 17 00:00:00 2001 From: Janhvi Harwani Date: Thu, 23 May 2024 18:49:29 -0700 Subject: [PATCH 03/11] Resolved all the PR comments --- .github/config.yml | 2 +- .../hudson/diagnosis/MemoryUsageMonitor/index.jelly | 2 +- .../hudson/model/DirectoryBrowserSupport/dir.jelly | 6 +++--- core/src/main/resources/jenkins/model/Jenkins/_404.jelly | 2 +- core/src/main/resources/jenkins/model/Jenkins/oops.jelly | 2 +- core/src/main/resources/lib/layout/dropdowns/custom.jelly | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/config.yml b/.github/config.yml index a0542b426f96..d4d920efb3d2 100644 --- a/.github/config.yml +++ b/.github/config.yml @@ -20,6 +20,6 @@ firstPRMergeComment: > - jenkins welcome page + ${%Jenkins diff --git a/core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly b/core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly index b2c710068e04..b4bc3844830a 100644 --- a/core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly +++ b/core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly @@ -61,7 +61,7 @@ THE SOFTWARE.
- null + memory usage monitor graph diff --git a/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly b/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly index 6760625b676c..8a8ac5ed5fc6 100644 --- a/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly +++ b/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly @@ -50,13 +50,13 @@ THE SOFTWARE. ${%No files in directory}

- null + symlink alert ${%Symlinks are hidden}

- null + temporary directory warning ${%Tmp directories are hidden}

@@ -130,7 +130,7 @@ THE SOFTWARE.

- warning image + temporary directory warning ${%Tmp directories are hidden}

diff --git a/core/src/main/resources/jenkins/model/Jenkins/_404.jelly b/core/src/main/resources/jenkins/model/Jenkins/_404.jelly index f4e1d8cc2230..cb6ebf2f1f74 100644 --- a/core/src/main/resources/jenkins/model/Jenkins/_404.jelly +++ b/core/src/main/resources/jenkins/model/Jenkins/_404.jelly @@ -34,7 +34,7 @@ THE SOFTWARE.

- null + page not found ${%Oops!}

diff --git a/core/src/main/resources/jenkins/model/Jenkins/oops.jelly b/core/src/main/resources/jenkins/model/Jenkins/oops.jelly index 4de7d295fa4f..fabdd175cbcb 100644 --- a/core/src/main/resources/jenkins/model/Jenkins/oops.jelly +++ b/core/src/main/resources/jenkins/model/Jenkins/oops.jelly @@ -32,7 +32,7 @@ THE SOFTWARE.

- null ${%Oops!} + ${%Oops!}

${%problemHappened}

diff --git a/core/src/main/resources/lib/layout/dropdowns/custom.jelly b/core/src/main/resources/lib/layout/dropdowns/custom.jelly index d93ef656329e..16884ce587bc 100644 --- a/core/src/main/resources/lib/layout/dropdowns/custom.jelly +++ b/core/src/main/resources/lib/layout/dropdowns/custom.jelly @@ -31,7 +31,7 @@ THE SOFTWARE. - null + Jenkins logo ]]> From e16257d4eed464ea3858fc2ed7a9d8a3488cb6da Mon Sep 17 00:00:00 2001 From: Janhvi Harwani Date: Thu, 23 May 2024 19:00:16 -0700 Subject: [PATCH 04/11] Updated alt image messages for dir.jelly, _404_simple.jelly and executors.jelly --- .../resources/hudson/model/DirectoryBrowserSupport/dir.jelly | 2 +- core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly | 2 +- core/src/main/resources/lib/hudson/executors.jelly | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly b/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly index 8a8ac5ed5fc6..45b085ecb428 100644 --- a/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly +++ b/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly @@ -124,7 +124,7 @@ THE SOFTWARE.

- warning image + symlink warning ${%Symlinks are hidden}

diff --git a/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly b/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly index 55033cec0c15..1e06df6912af 100644 --- a/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly +++ b/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly @@ -48,7 +48,7 @@ THE SOFTWARE.

- null + page not found ${%Oops!}

diff --git a/core/src/main/resources/lib/hudson/executors.jelly b/core/src/main/resources/lib/hudson/executors.jelly index d34a0a3c0595..dfc95c21626b 100644 --- a/core/src/main/resources/lib/hudson/executors.jelly +++ b/core/src/main/resources/lib/hudson/executors.jelly @@ -41,7 +41,7 @@ THE SOFTWARE. - (error image ${%offline}) + (Agent offline ${%offline}) (${%launching}) From b782620031c350f2bd40768ba2eaadb99e6916f6 Mon Sep 17 00:00:00 2001 From: Mark Waite Date: Sat, 27 Jul 2024 03:38:51 -0600 Subject: [PATCH 05/11] Do not attempt to localize Jenkins welcome page alt text --- .github/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/config.yml b/.github/config.yml index d4d920efb3d2..b458ff69b029 100644 --- a/.github/config.yml +++ b/.github/config.yml @@ -20,6 +20,6 @@ firstPRMergeComment: > - ${%Jenkins + Jenkins welcome page From 87d4ab46b2b736176cc328e53e70bf6169663774 Mon Sep 17 00:00:00 2001 From: Mark Waite Date: Sat, 27 Jul 2024 03:43:04 -0600 Subject: [PATCH 06/11] More clearly describe the participate link The destination page is describing the Jenkins project, not just Jenkins core. Addresses the comment in: https://github.com/jenkinsci/jenkins/pull/9296#discussion_r1608916860 --- .github/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/config.yml b/.github/config.yml index b458ff69b029..bf4285c74bef 100644 --- a/.github/config.yml +++ b/.github/config.yml @@ -20,6 +20,6 @@ firstPRMergeComment: > - Jenkins welcome page + Participate in and contribute to the Jenkins project From 904cb3e4ac582523f2db3d70c1404cad5f8facb7 Mon Sep 17 00:00:00 2001 From: Mark Waite Date: Sat, 27 Jul 2024 03:47:44 -0600 Subject: [PATCH 07/11] Internationalize memory usage monitor graph --- .../resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly b/core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly index b4bc3844830a..e4c9e804dbd2 100644 --- a/core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly +++ b/core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly @@ -61,7 +61,7 @@ THE SOFTWARE.
- memory usage monitor graph + ${%memory usage monitor graph} From 8d861dd926cf9ee32b77b592a84b6c6bf143ef67 Mon Sep 17 00:00:00 2001 From: Mark Waite Date: Sat, 27 Jul 2024 03:52:37 -0600 Subject: [PATCH 08/11] Use empty alt text when immediately followed by text As noted by Daniel Beck, it does not help the user of the screen reader for us to show the same fundamental text message twice. The image in these cases is a hint for the reader of the message text that immediately follows the image. Cluttering the screen reader content with a second copy of the same message is not helpful. --- .../hudson/model/DirectoryBrowserSupport/dir.jelly | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly b/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly index 45b085ecb428..bea0801ec867 100644 --- a/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly +++ b/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly @@ -50,13 +50,13 @@ THE SOFTWARE. ${%No files in directory}

- symlink alert + ${%Symlinks are hidden}

- temporary directory warning + ${%Tmp directories are hidden}

@@ -124,13 +124,13 @@ THE SOFTWARE.

- symlink warning + ${%Symlinks are hidden}

- temporary directory warning + ${%Tmp directories are hidden}

From 690501b89e23633c670e3a95ddf1b1469121b4ba Mon Sep 17 00:00:00 2001 From: Mark Waite Date: Sat, 27 Jul 2024 04:16:24 -0600 Subject: [PATCH 09/11] Use empty alt text in dropdown documentation example --- core/src/main/resources/lib/layout/dropdowns/custom.jelly | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/main/resources/lib/layout/dropdowns/custom.jelly b/core/src/main/resources/lib/layout/dropdowns/custom.jelly index 16884ce587bc..b563f95b74cd 100644 --- a/core/src/main/resources/lib/layout/dropdowns/custom.jelly +++ b/core/src/main/resources/lib/layout/dropdowns/custom.jelly @@ -31,7 +31,7 @@ THE SOFTWARE. - Jenkins logo + ]]> From 23d56f1cf8928bbe8388f4c0fde302779ee594e2 Mon Sep 17 00:00:00 2001 From: Mark Waite Date: Sat, 27 Jul 2024 04:22:33 -0600 Subject: [PATCH 10/11] Use empty alt text because nearby text already has the message No need to display the "not found" message twice in locations very near to each other. --- core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly b/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly index 1e06df6912af..520dd8482b00 100644 --- a/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly +++ b/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly @@ -48,7 +48,7 @@ THE SOFTWARE.

- page not found + ${%Oops!}

From f1101803c461694f105dcb1f47bf3487758cb5c3 Mon Sep 17 00:00:00 2001 From: Mark Waite Date: Sat, 27 Jul 2024 04:23:34 -0600 Subject: [PATCH 11/11] Use empty alt text - nearby text already provides details --- core/src/main/resources/jenkins/model/Jenkins/_404.jelly | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/main/resources/jenkins/model/Jenkins/_404.jelly b/core/src/main/resources/jenkins/model/Jenkins/_404.jelly index cb6ebf2f1f74..d7433188a87f 100644 --- a/core/src/main/resources/jenkins/model/Jenkins/_404.jelly +++ b/core/src/main/resources/jenkins/model/Jenkins/_404.jelly @@ -34,7 +34,7 @@ THE SOFTWARE.

- page not found + ${%Oops!}