Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkinsutility #4204

Open
Simplify3x opened this issue Nov 27, 2024 · 20 comments
Open

jenkinsutility #4204

Simplify3x opened this issue Nov 27, 2024 · 20 comments
Labels
hosting-request Request to host a component in jenkinsci needs-fix security-audit-todo The security team needs to audit the hosting request code

Comments

@Simplify3x
Copy link
Contributor

Simplify3x commented Nov 27, 2024

Repository URL

https://github.com/Simplify3x/SimplifyQA-Pipeline-Executor-Plugin

New Repository Name

SimplifyQA-Pipeline-Executor-Plugin

Description

when i build the plugins with the parameters,it will execute the testcase and execute the pipelines in simplifyQA.

GitHub users to have commit permission

Jenkins project users to have release permission

Issue tracker

GitHub issues

@Simplify3x Simplify3x added the hosting-request Request to host a component in jenkinsci label Nov 27, 2024
@jenkins-cert-app
Copy link
Collaborator

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

  • /audit-ok => the audit is complete, the hosting can continue 🎉.
  • /audit-skip => the audit is not necessary, the hosting can continue 🎉.
  • /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

  • /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
  • /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.31.144)

@jenkins-cert-app jenkins-cert-app added the security-audit-todo The security team needs to audit the hosting request code label Nov 27, 2024
@jenkins-cert-app
Copy link
Collaborator

❌ Jenkins Security Scan failed.
The Security team was notified about this.

Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: The origin repository 'https://github.com/Simplify3x/jenkins-utility.git' ends in .git, please remove this
  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @Simplify3x (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @Simplify3x (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: Repository URL 'https://github.com/Simplify3x/jenkins-utility' is not a valid GitHub repository (check that you do not have .git at the end, GitHub API doesn't support this).
  • ⚠️ Warning: No pom.xml detected.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@Wadeck
Copy link
Collaborator

Wadeck commented Nov 27, 2024

FYI the security scan failed because the repo content is not recognized (it's currently empty)

@Simplify3x please push your branch Dev to master, otherwise it will mess with the tooling I think

Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: Please add a license file to your repo, GitHub provides an easy mechanism to do this from their user interface.
  • ⚠️ Warning: No pom.xml detected.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@Simplify3x
Copy link
Contributor Author

done all the changes please host asap

@timja
Copy link
Member

timja commented Nov 29, 2024

/hosting re-check

Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: Please add a license file to your repo, GitHub provides an easy mechanism to do this from their user interface.
  • ⚠️ Warning: No pom.xml detected.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@Simplify3x
Copy link
Contributor Author

already i have added the license.txt
in the repo

@timja
Copy link
Member

timja commented Dec 2, 2024

your repo is empty: https://github.com/Simplify3x/jenkins-utility except for a README

see:

FYI the security scan failed because the repo content is not recognized (it's currently empty)

@Simplify3x please push your branch Dev to master, otherwise it will mess with the tooling I think

@Simplify3x
Copy link
Contributor Author

there is a branch master which has everything

@timja
Copy link
Member

timja commented Dec 2, 2024

Well your default branch is main and it has nothing, your plugin needs to be in the default branch

@Simplify3x
Copy link
Contributor Author

kindly review code is now pushed to the main default branch

@timja
Copy link
Member

timja commented Dec 2, 2024

/hosting re-check

Copy link

github-actions bot commented Dec 2, 2024

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: The dependency org.json:json should be replaced with a dependency to the api plugin io.jenkins.plugins:json-api
  • ⛔ Required: The 'artifactId' from the pom.xml (jenkinsutility) should not contain "Jenkins"
  • ⛔ Required: The 'artifactId' from the pom.xml (jenkinsutility) is incorrect, it should be jenkins-utility ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@timja
Copy link
Member

timja commented Dec 2, 2024

Without looking into the code initial feedback:

  1. What does this plugin do? - This should be captured in the README which is full of TODOs
  2. jenkins-utility-plugin is not an appropriate name for a plugin
  3. Please delete the 'junk' at the root of the repo, the files ending with .log and the git file
  4. You should only have one license file, choose one and delete the other

Copy link

github-actions bot commented Dec 2, 2024

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: The dependency org.json:json should be replaced with a dependency to the api plugin io.jenkins.plugins:json-api
  • ⛔ Required: The 'artifactId' from the pom.xml (jenkinsutility) should not contain "Jenkins"
  • ⛔ Required: The 'artifactId' from the pom.xml (jenkinsutility) is incorrect, it should be simplifyqa-pipeline-executor-plugin ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@Simplify3x
Copy link
Contributor Author

have updated the above requirements

@Simplify3x
Copy link
Contributor Author

kindly update me the required time for hosting

@timja
Copy link
Member

timja commented Dec 3, 2024

kindly update me the required time for hosting

Please put forward a better case for hosting, review your documentation and code, we need to be able to understand what your plugin is and why its beneficial that it should be hosted.

  1. Title in README doesn't map to your plugin name
  2. Please review your markdown rendering is broken is almost every section
  3. Do not recommend installing from source, instructions should default to downloading from Manage plugins
  4. Review your code ensuring you use your own java package and not sample
  5. You're missing support for proxies in https://github.com/Simplify3x/SimplifyQA-Pipeline-Executor-Plugin/blob/main/src/main/java/io/jenkins/plugins/sample/service/ExecutionService.java#L36, please take a look at ProxyConfiguration in Jenkins core
  6. Removed commented out code https://github.com/Simplify3x/SimplifyQA-Pipeline-Executor-Plugin/blob/main/src/main/java/io/jenkins/plugins/sample/model/Execution.java, https://github.com/Simplify3x/SimplifyQA-Pipeline-Executor-Plugin/blob/main/src/main/java/io/jenkins/plugins/sample/model/Metadata.java
  7. Nothing seems to call this? https://github.com/Simplify3x/SimplifyQA-Pipeline-Executor-Plugin/blob/89f68a46dc9e4deb158b2228b5b377327a687297/src/main/java/io/jenkins/plugins/sample/service/ExecutionService.java#L18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hosting-request Request to host a component in jenkinsci needs-fix security-audit-todo The security team needs to audit the hosting request code
Projects
None yet
Development

No branches or pull requests

4 participants