Activity Page does not support Filtering and Pagination together correctly

[PeachesMLG]

Describe The Bug
The Activity Page does not support Filtering and Pagination together due to doing pagination on server side, and filtering on the client side.
This means If you set a filter for a user, it only filters the results on the current page you are on.
e.g. Page1 may return 0 results, Page 2 may return 2 results, page 3 5 ect.

Steps To Reproduce
This is demenstrated best on an account that doesnt use jellyfin often

1. Go to the activity page
2. Create a filter (e.g. filter by a user)
3. Navigate through the pages and see the problem

Screenshots
Page 1

Page 2

System (please complete the following information):

• Platform: Browser
• Browser: Firefox
• Jellyfin Version: 10.9.11

[A7Lavinraj]

That means filtering should be done first before pagination, right?

[thornbill]

It's definitely not ideal, but this is currently working as intended. Pagination happens on the backend because the query can be slow (I have 126,000+ entries on my main server) and filtering happens on the frontend because the api does not support filtering. We might be able to add some logic to fetch additional rows if filtering results in less than the page size but that doesn't appear to be something that is supported "out of the box" with the table library.

[PeachesMLG]

It's definitely not ideal, but this is currently working as intended. Pagination happens on the backend because the query can be slow (I have 126,000+ entries on my main server) and filtering happens on the frontend because the api does not support filtering. We might be able to add some logic to fetch additional rows if filtering results in less than the page size but that doesn't appear to be something that is supported "out of the box" with the table library.

When you say the API doesnt support it, do you mean the Jellyfin server API doesnt have a filter option on the query?
or the Material React Table Library doesnt support server side filtering?

[thornbill]

The user activity API in the Jellyfin server does not support filtering.

[A7Lavinraj]

So what we have to build anyways(filtering?), like give some hints to do it

[PeachesMLG]

The user activity API in the Jellyfin server does not support filtering.

So from what I can see it has Date and UserId filtering
https://github.com/jellyfin/jellyfin/blob/master/Jellyfin.Api/Controllers/ActivityLogController.cs#L49
I guess it potentially needs a Level and Type filter aswell? Is there anything else the backend would need in order for this to work that im missing?

[Dan-613]

Just thinking about working on this and adding filtering server-side, however it might be slow to return results if the Activity Logs are big since the Type is stored as a string unless we add an index on the type.

Is it worth it to add Type and Level filtering server-side if an index is required?

[thornbill]

So from what I can see it has Date and UserId filtering

https://github.com/jellyfin/jellyfin/blob/master/Jellyfin.Api/Controllers/ActivityLogController.cs#L49

I guess it potentially needs a Level and Type filter aswell? Is there anything else the backend would need in order for this to work that im missing?

This is not correct. You can only currently filter on system vs user events and get the activity since a specific date.

[Dan-613]

This is not correct. You can only currently filter on system vs user events and get the activity since a specific date.

The suggestion is to add Type and Level filtering on the server-side.

[viown]

Just thinking about working on this and adding filtering server-side, however it might be slow to return results if the Activity Logs are big since the Type is stored as a string unless we add an index on the type.

It might be a bit too complex to implement the required functionality to make it work on web as we'd need support for both sorting and filtering (for all columns) by query.

[Dan-613]

It might be a bit too complex to implement the required functionality to make it work on web as we'd need support for both sorting and filtering (for all columns) by query.

I don't mind giving it a try. Material React Table being used seems to support server-side querying and filtering.