Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not delete media from app #83

Closed
somethingGoneWrong opened this issue May 8, 2021 · 7 comments · Fixed by jellyfin/jellyfin-web#3031
Closed

can not delete media from app #83

somethingGoneWrong opened this issue May 8, 2021 · 7 comments · Fixed by jellyfin/jellyfin-web#3031

Comments

@somethingGoneWrong
Copy link

I have the latest server version and the latest git version of tizen app and when I try to delete a media from app this not work, if I try to delete the same media via web interface, jellyfin remove it correctly.
is this a know issue? where can i find the log to help you to fix this? thx

@dmitrylyzo
Copy link
Collaborator

Tizen app just wraps jellyfin-web, so it uses the same command as web (it lives in jellyfin-apiclient-javascript).

In Tizen 3 emulator:
Delete media works on jellyfin-server_20210505.37-unstable + latest jellyfin-tizen (with jellyfin/jellyfin-web@e27131e).
Also works on jellyfin-server_10.7.5-1 + the same app.

It is not easy to get logs from app: #79 (comment)
You can find the location of the server logs on the Dashboard home page.

When you click on Delete media, a message box with OK/Cancel buttons should appear. Did it show up?

@somethingGoneWrong
Copy link
Author

somethingGoneWrong commented May 8, 2021

When you click on Delete media, a message box with OK/Cancel buttons should appear. Did it show up?

no, nothing appears; after click on delete media the menu is closed

@dmitrylyzo
Copy link
Collaborator

no, nothing appears; after click on delete media the menu is closed

So, the problem is on the client side.
The same dialog is displayed when removing subtitles (external only). This also works on my TV (Tizen 4).

What version of Tizen?
Could you try to delete media using Samsung Browser (do not confirm deletion; need to check if the dialog appears)? In this case, you will use jellyfin-web from the server. It might be tricky without a keyboard.

@somethingGoneWrong
Copy link
Author

What version of Tizen?

server: 10.7.5
app JF: latest git
tizen TV: tv-2.3.0

Could you try to delete media using Samsung Browser (do not confirm deletion; need to check if the dialog appears)?

Yes, it works; when I try to delete a video I have a dialog box from tizen sdk, that ask me if I want to delete the media with two choice [yes, no]; and delete it.
maybe the problem is the creation of a tizen modal dialog from JF app?
strange thing is the use the JF from web broswer is smoother than the JF tizen app.
here some server log cleaned: https://pastebin.com/eLQdt03v

@dmitrylyzo
Copy link
Collaborator

dmitrylyzo commented May 9, 2021

maybe the problem is the creation of a tizen modal dialog from JF app?

Yeah, I think the same. Also Tizen 2.3 uses the old WebKit engine.
I checked the webOS 1.2 emulator (also WebKit) - it doesn't show dialog but removes media. Anyway, that's bad: missclick - and you've lost your media.
Tizen probably resolves with false.

strange thing is the use the JF from web broswer is smoother than the JF tizen app.

I suspect it is using a different engine.
Could you find out user agent of Samsung Browser? For example, go to https://shaka-player-demo.appspot.com/support.html
If it contains Chrome, that's why it works better.

For your case, you can change https://github.com/jellyfin/jellyfin-web/blob/e27131edf0462c557d1c53ea4ee65fa6f4ac5b5c/src/components/confirm/confirm.js#L63
to const confirm = customConfirm;
I checked this after I wrote. The custom dialog looks ugly - need to adapt the layout for fullscreen.

@somethingGoneWrong
Copy link
Author

Could you find out user agent of Samsung Browser?

mozilla gecko and other stuff
when I have some time I will try the modification on confirm.js file.

Another strange behavior is at the login screen, after I put the IP of the server the JF app ask me the username and password; that's ok, but when I typed the username and press OK button to the keyboard widget to close that and select the password field, the app try to connect to the JF server and not allow me to add a password, obviously it failed, my workaround is to fill the password field before the username and then after a failed login attempt fill the username field...
Is this a bug related for my old tizen sdk platform installed on TV? but this is another issue :)

@dmitrylyzo
Copy link
Collaborator

mozilla gecko and other stuff

Looks the same as app (WebKit). Then I don't know why it works smoother.

I always press Back to close the on-screen keyboard.
OK on the on-screen keyboard is like OK on the remote, i.e. Enter, which submits the login form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants