Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] how to reserve the spaces between emoji? #91

Open
Freed-Wu opened this issue Jul 11, 2023 · 6 comments
Open

[question] how to reserve the spaces between emoji? #91

Freed-Wu opened this issue Jul 11, 2023 · 6 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers verified This issue was already verified

Comments

@Freed-Wu
Copy link

Hello world! :smile: This is a test.

Acutual Behaviour

 <p>Hello world!<img class="emoji" title=":smile:" alt=":smile:" raw="😄" src="https://github.githubassets.com/images/icons/emoji/unicode/1f604.png" style="vertical-align: middle; display: inline; max-width: 1em; visibility: hidden;" onload="this.style.visibility='visible'" onerror="this.replaceWith(this.getAttribute('raw'))">This is a test.</p>

Screenshot from 2023-07-12 05-03-25

Expected

 <p>Hello world! <img class="emoji" title=":smile:" alt=":smile:" raw="😄" src="https://github.githubassets.com/images/icons/emoji/unicode/1f604.png" style="vertical-align: middle; display: inline; max-width: 1em; visibility: hidden;" onload="this.style.visibility='visible'" onerror="this.replaceWith(this.getAttribute('raw'))"> This is a test.</p>

Screenshot from 2023-07-12 05-03-47

@jeffreytse jeffreytse self-assigned this Jul 13, 2023
@jeffreytse jeffreytse added good first issue Good for newcomers bug Something isn't working verified This issue was already verified labels Jul 13, 2023
@jeffreytse
Copy link
Owner

Hi @Freed-Wu,

Thanks for your reporting, I've settled down your issue, and please try with the latest version again.

Thanks & Regards

@Freed-Wu
Copy link
Author

Good. Is there any project to release a new version?

@jeffreytse
Copy link
Owner

Hi @Freed-Wu, you can update your plugin with the repository's master branch in the Gemfile as below snippet. : )

gem 'jekyll-spaceship', git: 'https://github.com/jeffreytse/jekyll-spaceship'

@Freed-Wu
Copy link
Author

gem 'jekyll-spaceship', git: 'https://github.com/jeffreytse/jekyll-spaceship'

My Gemfile is

# frozen_string_literal: true

source 'https://rubygems.org'

require 'yaml'
config = YAML.load_file('_config.yml')
config['plugins'].each do |plugin|
  gem plugin
end

@Freed-Wu
Copy link
Author

Although I can use the source from github temporarily, I still recommend to release a new version at least it can let user download package from mirror of rubygems which is faster than github. 😄

@jeffreytse
Copy link
Owner

@Freed-Wu, I will try to release a new version as soon as possible. : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers verified This issue was already verified
Projects
None yet
Development

No branches or pull requests

2 participants