Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure utf encoding works for special characters. #19

Open
jeffreycwitt opened this issue Aug 17, 2017 · 3 comments
Open

make sure utf encoding works for special characters. #19

jeffreycwitt opened this issue Aug 17, 2017 · 3 comments

Comments

@jeffreycwitt
Copy link
Owner

we need to make sure utf encoding of characters (especially those with accents) works. Today I was working with a colleague in the editor, we opened one file the editor was showing codes for characters with accent marks. I'm not sure what codes they were (maybe ascii).

In any case, its a problem if the the encoding of special characters gets changed when opened in the editor. These changes will then get added to the commit history when saved.

@Alph2
Copy link

Alph2 commented Nov 4, 2017

Hi,
This is a very nice project. The unicode support is a problem though. I tried typing some greek and the rendering of diacritics is buggy: if you try typing ἄ (U+1F04) using dead keys (which is the standard), that is ᾿ then ´ then α, you'll end up with ῎ἄ (U+1FCE)(U+1F04) (showing up when you type the next key).

@jeffreycwitt
Copy link
Owner Author

jeffreycwitt commented Nov 6, 2017

Hmm, I just tried that on my Mac and I didn't run into the problem.

I'd love to make this work better for you. What kind of system are you using? Any other information to help me re-create the problem would be helpful.

@Alph2
Copy link

Alph2 commented Nov 6, 2017

Ok my bad!
This seems to be a browser issue: I run into it on Safari (11.0.1), but everything is fine on Firefox (56.0.2) or Chromium (62.0.3202.75). Hadn't thought of trying that before…
I am also on macOS; it's the same on a local install and on herokuapp.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants