Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up our HTML #30

Open
jeffreycharters opened this issue Sep 23, 2022 · 4 comments
Open

Clean up our HTML #30

jeffreycharters opened this issue Sep 23, 2022 · 4 comments
Assignees
@sarah-adewale
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jeffreycharters
Copy link
Owner

Time for a refactor!

At this point we sort of have a header and a main section. We should add some semantic HTML tags to make these distinction more clear and provide a better experience for people who may be using screen readers. This shouldn't take too long to do, but might require a bit of research into semantic HTML.
@jeffreycharters jeffreycharters added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 23, 2022
@sarah-adewale
Copy link

hi! i'd like to take a crack at this

@jeffreycharters
Copy link
Owner Author

Sure Sarah, it's all yours! Leave a comment if you need any assistance.

@jeffreycharters jeffreycharters added hacktoberfest-accepted Approved for Hacktoberfest hacktoberfest Can use for Hacktoberfest credit and removed hacktoberfest-accepted Approved for Hacktoberfest labels Sep 27, 2022
@michaella23
Copy link
Collaborator

I just realized this was an 'Issue'! Haha, I've submitted a PR with many changes to the HTML file. Used semantic HTML tags and classes, attempted to make code more readable by reducing all the white space and indenting appropriately.

@jeffreycharters jeffreycharters removed the hacktoberfest Can use for Hacktoberfest credit label Nov 12, 2022
@CBID2
Copy link
Contributor

CBID2 commented Feb 19, 2023

Has this issue been solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarah-adewale sarah-adewale

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jeffreycharters @sarah-adewale @michaella23 @CBID2