Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dismissable Review Request Notice? #6

Open
jdmdigital opened this issue May 21, 2019 · 2 comments
Open

Add Dismissable Review Request Notice? #6

jdmdigital opened this issue May 21, 2019 · 2 comments
Assignees
@jdmdigital
Labels
enhancement New feature or request question Further information is requested

Comments

@jdmdigital
Copy link
Owner

I think these things can be super-annoying, but might be a good idea so long as the following criteria has been met.

  • Check if the unofficial constant DISABLE_NAG_NOTICES is defined
  • It's been more than a week since the plugin was activated
  • The notice is dismissable--permanently
  • There is no "shame & blame" in the notice content

If that's done properly, I'm cool with adding this.
@jdmdigital jdmdigital added the question Further information is requested label May 21, 2019
@jdmdigital jdmdigital self-assigned this May 21, 2019
jdmdigital added a commit that referenced this issue May 21, 2019
@jdmdigital
Toward v1.2
43a0dac 
Addresses a few issues including #6  and #5
@jdmdigital
Copy link
Owner Author

Added. Testing.

jdmdigital added a commit that referenced this issue May 21, 2019
@jdmdigital
Testing Tweaks
03c919e 
Testing and improvements towards #6.  Fix #5.
@jdmdigital jdmdigital added the enhancement New feature or request label May 21, 2019
@jdmdigital
Copy link
Owner Author

Waiting 8 days to see if this works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdmdigital jdmdigital

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdmdigital