Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching Implementation Inconsistencies #179

Open
nnordrum opened this issue Mar 25, 2019 · 37 comments
Open

Caching Implementation Inconsistencies #179

nnordrum opened this issue Mar 25, 2019 · 37 comments

Comments

@nnordrum
Copy link

There currently (that I'm aware of) isn't a way to externalize the cache to a Reddis/Cassandra/etc.

There are a number of caching wires that are unable to do the job:

  • AbstractHeaderBasedCachingWire.java: cache is a transient Map that isn't user replaceable
  • CachingWire.java: uses guava Map, so probably the closest, but not easy/documented how to do it
  • FcWire.java: cache root is a directory, and FcCache is final and not an Interface

All of these are close, but no cigar.

What I'm specifically trying to do is create a Wire (GitHubWire.java) that supports a pluggable cache and supports ETag. AbstractHeaderBasedCachingWire.java would be perfect if I could just swap out the caching implementation...

@0crat
Copy link

0crat commented Mar 25, 2019

@yegor256/z please, pay attention to this issue

@0crat
Copy link

0crat commented Mar 25, 2019

@nnordrum/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@nnordrum
Copy link
Author

I realize jcabi/jcabi-github may be the right place the this, but here had more wires.

@andreoss
Copy link
Collaborator

andreoss commented Jul 8, 2020

@nnordrum Would an extra constructor with Map parameter added in AbstractHeaderBasedCachingWire be enough?
Note, only 4 Map methods are used by this class (put,get,remove, contains), so may be it should not be a Map.
CachingWire keeps its cache it in static private variable, it could refactor in order to be used like .through(CachingWire.class, cache), though we would need an extract interface for this cache object.

@0crat
Copy link

0crat commented Jul 9, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 14, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 19, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 24, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 29, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 3, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 8, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@yegor256
Copy link
Member

yegor256 commented Aug 9, 2020

@andreoss what's up with this ticket?

@0crat
Copy link

0crat commented Aug 13, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 18, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@andreoss
Copy link
Collaborator

@yegor256 I would go with extra parameter to CachingWire, if you're okay with that
#179 (comment)

@yegor256
Copy link
Member

@andreoss yes, it's fine

@0crat
Copy link

0crat commented Aug 23, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 28, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

andreoss added a commit to andreoss/jcabi-http that referenced this issue Sep 2, 2020
andreoss added a commit to andreoss/jcabi-http that referenced this issue Sep 2, 2020
andreoss added a commit to andreoss/jcabi-http that referenced this issue Sep 2, 2020
andreoss added a commit to andreoss/jcabi-http that referenced this issue Sep 2, 2020
andreoss added a commit to andreoss/jcabi-http that referenced this issue Sep 2, 2020
@0crat
Copy link

0crat commented Sep 2, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

andreoss added a commit to andreoss/jcabi-http that referenced this issue Sep 3, 2020
andreoss added a commit to andreoss/jcabi-http that referenced this issue Sep 3, 2020
@0pdd
Copy link

0pdd commented Sep 3, 2020

@nnordrum the puzzle #222 is still not solved.

@0crat
Copy link

0crat commented Sep 7, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Sep 12, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Sep 18, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Sep 23, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Sep 28, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Oct 3, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Oct 8, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Oct 13, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Oct 18, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Oct 23, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Oct 28, 2020

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0pdd
Copy link

0pdd commented Jul 4, 2022

@nnordrum the puzzle #332 is still not solved.

@0pdd
Copy link

0pdd commented Jul 19, 2022

@nnordrum the puzzle #unknown is still not solved; solved: #332.

@0crat
Copy link

0crat commented Aug 1, 2022

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 6, 2022

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 11, 2022

@yegor256/z everybody who has role DEV is banned at #179; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@yegor256 yegor256 self-assigned this Aug 11, 2022
@yegor256 yegor256 removed their assignment Sep 10, 2022
@0crat
Copy link

0crat commented Sep 10, 2022

@yegor256/z I see that you unassigned this issue; the order is still assigned to @yegor256/z though; to cancel the order use refuse, as in §6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants