Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 5.0: Choices not working #616

Open
MiltosD opened this issue Apr 19, 2024 · 1 comment
Open

Django 5.0: Choices not working #616

MiltosD opened this issue Apr 19, 2024 · 1 comment

Comments

@MiltosD
Copy link

MiltosD commented Apr 19, 2024

Problem

In Django 5.0 field choices seem to be always lists, even when defined as Choices. In Django 4.3.9 it seems to be working as expected.

Environment

  • Django Model Utils version: 4.5.0
  • Django version: 5.0
  • Python version: 3.10
  • Other libraries used, if any:

Code examples

from model_utils import Choices

class MyClass
	my_field = models.CharField(
		   choices=Choices(("M", "Male", "MALE"), ("F", "Female", "FEMALE"))
	)

Django 4.2.11

from models import MyModel
type(MyModel._meta.get_field("my_field").choices)
<class 'model_utils.choices.Choices'>
MyModel._meta.get_field("my_field").choices
Choices(("M", "Male", "MALE"), ("F", "Female", "FEMALE"))

Django 5.0

from models import MyModel
type(MyModel._meta.get_field("my_field").choices)
<class 'list'>
MyModel._meta.get_field("my_field").choices
[("M", "MALE"), ("F", "FEMALE")]

This raises an error

TypeError: list indices must be integers or slices, not str

when trying to

MyModel._meta.get_field("my_field").choices["M"]
@foarsitter
Copy link
Contributor

Can you provide a PR with a failing testcase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants