Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Framework [Suggestion] #10

Open
steveoni opened this issue Jan 22, 2021 · 11 comments
Open

CSS Framework [Suggestion] #10

steveoni opened this issue Jan 22, 2021 · 11 comments

Comments

@steveoni
Copy link
Member

@AceTheCreator I will suggest we make use of tailwind css to ease prototyping. I've set up the tailwind configuration and everything needed to enable tailwind

@AceTheCreator
Copy link
Member

@steveoni i don't think that'll be necessary because the UI has been done already. I was planning on submitting a pull request today but I'm having issue with my Pc. The only thing remaining is just the default functions output.
E.g. Load_csv, load_package e.t.c.

@steveoni
Copy link
Member Author

ok, if that so, you can just pull and discard my changes.

and for the load_csv and load_package, we can easily copy and paste that from the Dnotebook itself into this current version.

@AceTheCreator
Copy link
Member

@steveoni sorry for the delay on the project. I just got my system fixed today, so i'll hop on the project ASAP

@AceTheCreator
Copy link
Member

@steveoni I'm really sorry for the projects delay, I had some personal issue that made me put a pause on the project last month. I'm fully back now and I've continued working on it.

@AceTheCreator
Copy link
Member

@steveoni i was thinking should there be a message when a package successfully loads or it should just be blank as seen below in cell one.
Screenshot from 2021-03-09 22-53-54

@steveoni
Copy link
Member Author

@steveoni I'm really sorry for the projects delay, I had some personal issue that made me put a pause on the project last month. I'm fully back now and I've continued working on it.

Hi @AceTheCreator , how you doing, hope it is not something too critical. Great to hear from you again

@steveoni
Copy link
Member Author

@steveoni i was thinking should there be a message when a package successfully loads or it should just be blank as seen below in cell one. Screenshot from 2021-03-09 22-53-54

That will be okay. But we can also have a spinner to indicate the file is loading. Awesome work. you create a pull request for this

@AceTheCreator
Copy link
Member

@steveoni I'm really sorry for the projects delay, I had some personal issue that made me put a pause on the project last month. I'm fully back now and I've continued working on it.

Hi @AceTheCreator , how you doing, hope it is not something too critical. Great to hear from you again

Thanks man

@AceTheCreator
Copy link
Member

@steveoni i was thinking should there be a message when a package successfully loads or it should just be blank as seen below in cell one. Screenshot from 2021-03-09 22-53-54

That will be okay. But we can also have a spinner to indicate the file is loading. Awesome work. you create a pull request for this

Ok. I'll implement the features mentioned above and create a pull request.

@AceTheCreator
Copy link
Member

@steveoni implemented the feature mentioned above.

@risenW
Copy link
Member

risenW commented Mar 18, 2021

@AceTheCreator My bad, I'm just seeing this update now. Great work! I just saw your PR. @steveoni will review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants