Skip to content

Commit f6a049d

Browse files
committed
When same user reviews as APPROVED and then COMMENTED, still show as APPROVED
1 parent 14a6e97 commit f6a049d

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

lib/github.rb

+7-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,13 @@ def self._pr_data(pr)
2525
result["author"] = name_and_login(pr["author"])
2626

2727
result["reviews"] = pr["reviews"]["nodes"].inject({}) do |reviews, review|
28-
reviews.merge({ name_and_login(review["author"]) => review["state"] })
28+
key = name_and_login(review["author"])
29+
if reviews[key] && review["state"] == "COMMENTED"
30+
# if reviewer APPROVED and then COMMENTED, keep as APPROVED
31+
reviews
32+
else
33+
reviews.merge({ key => review["state"] })
34+
end
2935
end
3036

3137
result["reviewRequests"] = pr["reviewRequests"]["nodes"].map do |rr|

0 commit comments

Comments
 (0)