Skip to content

Commit e051a49

Browse files
committed
Add some type hints to help with ServerConnection.connect.
Ref #230
1 parent 63599db commit e051a49

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

irc/client.py

+11-8
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@
4545
.. [IRC specifications] http://www.irchelp.org/irchelp/rfc/
4646
"""
4747

48+
from __future__ import annotations
49+
4850
import abc
4951
import base64
5052
import bisect
@@ -60,6 +62,7 @@
6062
import threading
6163
import time
6264
import warnings
65+
from typing import Callable
6366

6467
import jaraco.functools
6568
from jaraco.functools import Throttler
@@ -131,14 +134,14 @@ def __init__(self, reactor):
131134
@jaraco.functools.save_method_args
132135
def connect(
133136
self,
134-
server,
135-
port,
136-
nickname,
137-
password=None,
138-
username=None,
139-
ircname=None,
137+
server: str,
138+
port: int,
139+
nickname: str,
140+
password: str | None = None,
141+
username: str | None = None,
142+
ircname: str | None = None,
140143
connect_factory=connection.Factory(),
141-
sasl_login=None,
144+
sasl_login: str | None = None,
142145
):
143146
"""Connect/reconnect to a server.
144147
@@ -169,7 +172,7 @@ def connect(
169172
self.disconnect("Changing servers")
170173

171174
self.buffer = self.buffer_class()
172-
self.handlers = {}
175+
self.handlers: dict[str, Callable] = {}
173176
self.real_server_name = ""
174177
self.real_nickname = nickname
175178
self.server = server

0 commit comments

Comments
 (0)