Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Update the swagger page with /models/pull #4263

Open
pelikhan opened this issue Dec 11, 2024 · 5 comments
Open

bug: Update the swagger page with /models/pull #4263

pelikhan opened this issue Dec 11, 2024 · 5 comments
Assignees
@louis-jan
Labels
category: local API server Server page UI UX type: bug Something isn't working type: docs Improvements or additions to documentation
Milestone
v0.5.13

Comments

@pelikhan
Copy link

I can't seem to download a model through the server API. I started the server, opened the swagger ui and ran the default model id with models/download.

The response is always 200 / message : Model not found.

(a http error code would be nice too when not found )
@github-project-automation github-project-automation bot moved this to Investigating in Jan & Cortex Dec 11, 2024
@imtuyethan imtuyethan changed the title models/download/modelid always returns model not found bug: Can't download models through API server Dec 12, 2024
@imtuyethan imtuyethan added type: bug Something isn't working category: local API server Server page UI UX labels Dec 12, 2024
@louis-jan
Copy link
Contributor

@pelikhan Could you please share the curl request so that we can investigate it further?

@pelikhan
Copy link
Author

To repro, start server, open swagger console and run the models/download default value

image

@imtuyethan
Copy link
Contributor

imtuyethan commented Dec 13, 2024 •
edited
Loading

@pelikhan We moved from /models/download to /models/pull and forgot to update the swagger page, so sorry about this. We'll fix it soon.

@imtuyethan imtuyethan moved this from Investigating to Scheduled in Jan & Cortex Dec 13, 2024
@imtuyethan imtuyethan assigned urmauur and unassigned TC117 and louis-jan Dec 13, 2024
@imtuyethan imtuyethan changed the title bug: Can't download models through API server bug: Update the swagger page with /models/pull Dec 13, 2024
@imtuyethan imtuyethan added the type: docs Improvements or additions to documentation label Dec 13, 2024
@imtuyethan imtuyethan added this to the v0.5.12 milestone Dec 13, 2024
@pelikhan pelikhan mentioned this issue Dec 13, 2024
Closed
@pelikhan
Copy link
Author

An API matching ollama would be nice (get /api/show, post /api/pull)

@urmauur urmauur assigned louis-jan and unassigned urmauur Dec 16, 2024
@imtuyethan imtuyethan modified the milestones: v0.5.12, v0.5.13 Dec 18, 2024
@imtuyethan
Copy link
Contributor

imtuyethan commented Dec 18, 2024 •
edited
Loading

@louis-jan louis-jan mentioned this issue Dec 19, 2024
Merged
@louis-jan louis-jan moved this from Scheduled to Eng Review in Jan & Cortex Dec 19, 2024
@louis-jan louis-jan moved this from Eng Review to QA in Jan & Cortex Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louis-jan louis-jan

Labels
category: local API server Server page UI UX type: bug Something isn't working type: docs Improvements or additions to documentation
Projects
Jan & Cortex
Status: QA
Milestone
v0.5.13
Development

No branches or pull requests
5 participants
@pelikhan @urmauur @TC117 @imtuyethan @louis-jan