Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: [0.5.10] Model parameter values show unexpected precision between storage & logs #4210

Open
1 of 3 tasks
imtuyethan opened this issue Dec 3, 2024 · 3 comments
Open
1 of 3 tasks

bug: [0.5.10] Model parameter values show unexpected precision between storage & logs #4210

imtuyethan opened this issue Dec 3, 2024 · 3 comments
Assignees
@namchuai
Labels
category: model settings Inference params, presets, templates type: bug Something isn't working

Comments

@imtuyethan
Copy link
Contributor

imtuyethan commented Dec 3, 2024 •
edited
Loading

Jan version

0.5.10

Describe the Bug

Parameter values show different precision between storage and logs:

  • thread.json: temperature = 0.7
  • Logs: temperature = 0.6999999880790710

Luke said: This is a classicial com-scie thing, in short regardless of how many binary bits we prepare to store numbers, there will always be decimals which require more bits 😂😂😂 but this one is fixable from our side.

Steps to Reproduce

  1. Set temperature to 0.7 in GUI
  2. Check thread.json value
  3. Compare with log output

Screenshots / Logs

Screenshot 2024-12-03 at 9 43 26 PM

What is your OS?

  • MacOS
  • Windows
  • Linux
@imtuyethan imtuyethan added the type: bug Something isn't working label Dec 3, 2024
@github-project-automation github-project-automation bot moved this to Investigating in Jan & Cortex Dec 3, 2024
@imtuyethan imtuyethan moved this from Investigating to Scheduled in Jan & Cortex Dec 3, 2024
@imtuyethan imtuyethan added the category: model settings Inference params, presets, templates label Dec 3, 2024
@imtuyethan imtuyethan changed the title bug: Model parameter values show unexpected precision between storage & logs bug: [0.5.10] Model parameter values show unexpected precision between storage & logs Dec 3, 2024
@louis-jan
Copy link
Contributor

The screenshot above is about a different issue. This is the correct screenshot.
Image

@louis-jan louis-jan assigned namchuai and unassigned louis-jan Dec 4, 2024
@louis-jan
Copy link
Contributor

I think that is just about logging thing right? about the yaml parsing

@imtuyethan
Copy link
Contributor Author

I think that is just about logging thing right? about the yaml parsing

ye

@Glashkoff Glashkoff mentioned this issue Dec 4, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namchuai namchuai

Labels
category: model settings Inference params, presets, templates type: bug Something isn't working
Projects
Jan & Cortex
Status: Scheduled
Milestone
No milestone
Development

No branches or pull requests
3 participants
@namchuai @imtuyethan @louis-jan