Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planning: Cortex API supports basic /assistants (Jan status quo equivalent) #1573

Open
Tracked by #3909
dan-menlo opened this issue Oct 30, 2024 · 5 comments
Open
Tracked by #3909
Assignees
Labels
type: planning Opening up a discussion
Milestone

Comments

@dan-menlo
Copy link
Contributor

dan-menlo commented Oct 30, 2024

Goal

@dan-menlo dan-menlo added this to Menlo Oct 30, 2024
@dan-menlo dan-menlo converted this from a draft issue Oct 30, 2024
@dan-menlo dan-menlo changed the title planning: Cortex Assistants API planning: Cortex /assistants API and Data Structures Oct 30, 2024
@dan-menlo dan-menlo changed the title planning: Cortex /assistants API and Data Structures planning: Cortex API supports /assistants Oct 30, 2024
@dan-menlo
Copy link
Contributor Author

dan-menlo commented Oct 31, 2024

@namchuai @louis-jan For migration of Assistant, I think we can scope it down into two things:

Legacy "Assistants"

  • For legacy assistants, I think we should follow the strategy in /threads
  • v1 assistants should be handled by v1 thread.json assistants, and not exposed via API

Legacy Retrieval Tool

I would like to understand the possible approaches for us to handle this:

  • Option 1: Maintain as a legacy Retrieval tool (eg have a legacy API handler in Cortex)
  • Option 2: Migrate files, vector DB to Cortex?

I think it is easier for us to scope this to having legacy handlers and focus specifically on migration. With system stability, it is the possible for us to use v2 API handlers to build proper APIs, which will handle new Threads, Assistants and Tools

@dan-menlo dan-menlo assigned louis-jan and unassigned louis-jan Oct 31, 2024
@dan-menlo dan-menlo moved this from Investigating to Planning in Menlo Oct 31, 2024
@dan-menlo
Copy link
Contributor Author

dan-menlo commented Nov 17, 2024

@louis-jan @namchuai While this ticket is for a v1 of Assistants, I think we should project forward to the likely roadmap for Assistants:

We should evaluate this; if it is too messy or difficult to align with an OpenAI-compatible API, I am open with also just going with our own (e.g. Runs, etc).

@namchuai namchuai moved this from Planning to Scheduled in Menlo Dec 4, 2024
@louis-jan louis-jan added type: epic A major feature or initiative type: planning Opening up a discussion and removed type: epic A major feature or initiative labels Dec 4, 2024
@dan-menlo dan-menlo changed the title planning: Cortex API supports /assistants planning: Cortex API supports basic /assistants Dec 4, 2024
@dan-menlo dan-menlo changed the title planning: Cortex API supports basic /assistants planning: Cortex API supports basic /assistants (Jan status quo equivalent) Dec 4, 2024
@namchuai namchuai moved this from Scheduled to Eng Review in Menlo Dec 6, 2024
@namchuai namchuai added this to the v1.0.5 milestone Dec 6, 2024
@namchuai namchuai moved this from Eng Review to QA in Menlo Dec 6, 2024
@TC117
Copy link

TC117 commented Dec 12, 2024

Hi @namchuai, can you take a look at assistants endpoint
image
I tried with threads but that didn’t work either
Image

I did check and Jan have an assistants folder and I think Jan query assistant endpoint for this folder not from thread
image

curl -X 'GET' \
  'http://127.0.0.1:1337/v1/assistants' \
  -H 'accept: application/json'

Repsponse:
{
  "object": "list",
  "data": [
    {
      "avatar": "",
      "id": "jan",
      "object": "assistant",
      "created_at": 1733377512678,
      "name": "Jan",
      "description": "A default assistant that can use all downloaded models",
      "model": "*",
      "instructions": "",
      "tools": [
        {
          "type": "retrieval",
          "enabled": false,
          "useTimeWeightedRetriever": false,
          "settings": {
            "top_k": 2,
            "chunk_size": 1024,
            "chunk_overlap": 64,
            "retrieval_template": "Use the following pieces of context to answer the question at the end. If you don't know the answer, just say that you don't know, don't try to make up an answer.\n----------------\nCONTEXT: {CONTEXT}\n----------------\nQUESTION: {QUESTION}\n----------------\nHelpful Answer:"
          }
        }
      ],
      "file_ids": []
    }
  ]
}

@TC117 TC117 removed this from the v1.0.5 milestone Dec 16, 2024
@TC117 TC117 added this to the v1.0.6 milestone Dec 16, 2024
@TC117 TC117 modified the milestones: v1.0.6, v1.0.7 Dec 30, 2024
@TC117 TC117 modified the milestones: v1.0.7, v1.0.9 Jan 7, 2025
@TC117 TC117 self-assigned this Jan 7, 2025
@TC117
Copy link

TC117 commented Jan 10, 2025

Create new assistant
Image
Image
Image

@TC117
Copy link

TC117 commented Jan 10, 2025

But cant get assistant with ID
Image

@TC117 TC117 moved this from QA to Completed in Menlo Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: planning Opening up a discussion
Projects
Status: Completed
Development

No branches or pull requests

5 participants