Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview builds #3

Open
janbrasna opened this issue Dec 25, 2023 · 1 comment
Open

Preview builds #3

janbrasna opened this issue Dec 25, 2023 · 1 comment

Comments

@janbrasna
Copy link
Owner

janbrasna commented Dec 25, 2023

Easy with current /docs output, see Netlify PoC:

(Once changed to / for gh-pages deploy target check again what assets get published for noise, or consider some (other? like /build as when dev?) output folder and only publish its contents to gh-pages root? — needed anyways for local webpack output, tbd examine 3rdparty actions for webpack workflow inspiration deploying github-pages env instead of committing gh-pages to branch…)


General build OQs:

  • works only with node 14 (EOL), fails on 16; should be updated to current LTS which is 20!
    • (GH actions only support node16 starting this summer, so at least 16 compatibility must be resolved to be able to build webpack output to gh-pages using actions…)
    • webpack 4.46>4.47 update should support node18+…
  • has some rather old deps, worth trying to bring more up to date?
    • @gene1wood began updating to webpack5: gene1wood@4f8500d with all the deps, let's see if that resolves all the LTS compatibility & audit findings…
@janbrasna
Copy link
Owner Author

Prolly should build without prod env to skip GA?

    <% if (htmlWebpackPlugin.options.production) { %>
    <script async src="https://www.googletagmanager.com/gtag/js?id=UA-66267220-1"></script>
    <script src="/analytics.js"></script>
    <% } %>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant