Skip to content

Inconsistency in Chempy wrapper.py #13

@jan-rybizki

Description

@jan-rybizki

Found by Oliver:
In the main Chempy() function (in wrapper.py) when SSPs are created, they are initialized with the ISM metallicity at time-step i (i.e. cube.cube['Z'][i]) but the element fractions of one time-step before i.e. element_fractions = cube.cube[elements][max(i-1,0)]/cube.cube['gas'][max(i-1,0)]

Should try to change the time of the element fractions and see if chempy still runs stable. Why have I never written test code, btw?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions