Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate steps in applySamplePadding() #86

Open
nwolek opened this issue Feb 23, 2016 · 2 comments
Open

Eliminate steps in applySamplePadding() #86

nwolek opened this issue Feb 23, 2016 · 2 comments
Assignees

Comments

@nwolek
Copy link
Member

nwolek commented Feb 23, 2016

Detailed discussion in pull #83

@nwolek
Copy link
Member Author

nwolek commented Feb 23, 2016

Function can be found here: https://github.com/jamoma/jamoma2/blob/master/include/core/JamomaSample.h#L262

Lines 273-291 are the ones that we would like to improve / consolidate.

Test for this function can be found here: https://github.com/jamoma/jamoma2/blob/master/test/SampleBundle/SampleBundle.cpp#L215

@tap
Copy link
Member

tap commented Feb 25, 2016

specifically, this comment:

We made a copy up above (see my previous comment). But we shouldn't need to copy here. We should be able to move instead. Might have to use std::move here. @nwolek , please feel free to make me a ticket to investigate this. Even if we have to copy up above, maybe we can cut our trouble down here somewhat?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants