Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular Extension Clean-up #341

Open
tap opened this issue Mar 4, 2015 · 1 comment
Open

Modular Extension Clean-up #341

tap opened this issue Mar 4, 2015 · 1 comment

Comments

@tap
Copy link
Member

tap commented Mar 4, 2015

The Modular extensions are a mess!

  • Projects include cpp files from outside of the project folders
  • This code is included in other extensions and also the library
  • This code could (and should) have one definitive implementation (the library) and then simply be exported
  • These extensions don't link to Modular
  • Many of these files include multiple header guards -- e.g. Protocol.h -- was this two files that got merged and the person doing it was lazy or are we relying on the preprocessor define to turn off part of the file instead of the whole file or ???
  • These source define subclasses of TTObjectBase but make the constructors public which is "illegal"
  • Skeptical about the extremely widespread macro usage
  • Etc.

Further down the road (probably needs another ticket) there are design problems with some of these classes. For example, the schedulers are implemented in extensions that can be dynamically loaded but the list of schedulers is hard coded in the library??? Maybe I'm missing something, but that doesn't really make any sense.

I'll at least try to fix the weird build configuration problems. The design problems may wait...

@tap tap self-assigned this Mar 4, 2015
@tap tap added this to the Foundation Code Review milestone Mar 4, 2015
@tap
Copy link
Member Author

tap commented Mar 4, 2015

Adding to this frustration is that changing the code is nerve-wracking due to the total lack of unit tests in Modular. This is also a huge problem.

tap pushed a commit that referenced this issue Mar 4, 2015
…including source files from the lib -- CMake files will need to be updated. see #341.
@tap tap removed their assignment Mar 4, 2015
@tap tap removed the in progress label Mar 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant