Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

fileName parameter is ignored in dotnet version #128

Open
ghost opened this issue Apr 12, 2018 · 4 comments
Open

fileName parameter is ignored in dotnet version #128

ghost opened this issue Apr 12, 2018 · 4 comments

Comments

@ghost
Copy link

ghost commented Apr 12, 2018

Hi,

The functions AddOrUpdateValueInternal and GetValueOrDefaultInternal from the source file Settings.dotnet.cs are ignoring the fileName parameter. Is it on purpose ?
Do you plan to handle it in the future ?

@ncarandini
Copy link

This is documented here: FileName Parameter for .NET 4.5: Does not apply

@jamesmontemagno
Copy link
Owner

I am open to implementations and ideas.

@AndreiMisiukevich
Copy link
Contributor

AndreiMisiukevich commented May 20, 2018

@jamesmontemagno what about this idea
As I see, now we are creating separate file for every key.
So, we can create xml file for several keys. It will give as possibility to work with it in "dictionary mode".
Something like this https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/concepts/linq/how-to-work-with-dictionaries-using-linq-to-xml

One file can have such structure

<Root>  
  <key1 type="int">21</key1>  
  <key2 type="string">message</key2>  
  <key3 type="bool">False</key3>  
</Root>  

@AndreiMisiukevich
Copy link
Contributor

are there thoughts?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants