Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

May need to include numbers again #1

Open
jameshyen opened this issue Feb 22, 2017 · 0 comments
Open

May need to include numbers again #1

jameshyen opened this issue Feb 22, 2017 · 0 comments
Assignees

Comments

@jameshyen
Copy link
Owner

In Rip.js:

const space = /[\s]/;
const newline = /[\n]/;
const words = /^[a-zA-Z]+$/;
const punctWord = /^[a-zA-Z'‘’]+$/;
const punct = /[^a-zA-Z]/g;

Can't parse lyrics like this:

Yo 7L, tell me where the gat at? Nah scratch that, I'mma take the AT-AT

What about hyphens?

We eliminated exclamations marks, which makes sense, I guess.

@jameshyen jameshyen self-assigned this Feb 22, 2017
newrapcity referenced this issue in newrapcity/ExtraordinaryRhymes Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant