Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stock currency no longer right aligned #69

Open
Artistiqa opened this issue Feb 14, 2024 · 3 comments
Open

Stock currency no longer right aligned #69

Artistiqa opened this issue Feb 14, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Artistiqa
Copy link

Platform

Raspberry PI OS

Node.js Version

18.19.0

MagicMirror Version

2.20.0

Module Version

v2.9.3

Description

In the previous version, the currency used to be right aligned but now it's jagged since it's left aligned with the stock name.

I tried messing with the CSS to fix this, but nothing worked to help move the currency to the right.

Expected behavior

No response

Current behavior

No response

Possible solution

No response

Steps to reproduce

  1. Navigate to the MagicMirror/modules directory and execute the following command
    git clone https://github.com/jalibu/MMM-Jast
  2. Change into the MMM-Jast module folder and install runtime dependencies with
    cd MMM-Jast
    npm install
  3. Add the module sample configuration into the MagicMirror/config/config.js file:
  4. Update config.js
    currencyStyle: "symbol",
    displayMode: "none",

Log

No response

config.js

{
			module: "MMM-Jast",
			position: "top_right",
			header: "Stonks",
			config: {
				currencyStyle: "symbol", // One of ["code", "symbol", "name"]
				fadeSpeedInSeconds: 3.5,
				lastUpdateFormat: "HH:mm",
				maxChangeAge: 1 * 24 * 60 * 60 * 1000,
				maxWidth: "100%",
				numberDecimalsPercentages: 1,
				numberDecimalsValues: 2,
				displayMode: "none", // One of ["none", "vertical", "horizontal", "table"]
				showColors: false,
				showCurrency: true,
				showChangePercent: true,
				showChangeValue: false,
				showChangeValueCurrency: false,
				showHiddenStocks: false,
				showLastUpdate: false,
				showPortfolioValue: false,
				showPortfolioGrowthPercent: false,
				showPortfolioGrowth: false,
				showPortfolioPerformanceValue: false,
				showPortfolioPerformancePercent: false,
				showStockPerformanceValue: false,
				showStockPerformanceValueSum: false,
				showStockPerformancePercent: false,
				stocksPerPage: 2, // Only relevant for display mode "table"
				updateIntervalInSeconds: 300,
				useGrouping: false,
				virtualHorizontalMultiplier: 2,
				stocks: [
				  { name: 'SPDR S&P 500', symbol: 'SPY'},
				  { name: 'Vanguard', symbol: 'VOO'},
				  { name: 'Tesla', symbol: 'TSLA'},
				  { name: 'Apple', symbol: 'AAPL'}
						]
					}
		},

Additional info

No response

@Artistiqa Artistiqa added the bug Something isn't working label Feb 14, 2024
@jalibu
Copy link
Owner

jalibu commented Apr 17, 2024

Hi @Artistiqa
thank you for reporting this.
Can you post a screenshot of your problem?

@BakerThe4th
Copy link

Same issue...

image

@jalibu
Copy link
Owner

jalibu commented Apr 29, 2024

thanks for reporting that.

I can't say yet when I'll be able to take care of it, as I simply don't have the time at the moment.

Any fix PR is welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants