Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] The links is so blurry unless set this.graph.config.links_ontop to true, on HiDPI screens. #497

Open
cesaryuan opened this issue Sep 4, 2024 · 0 comments · May be fixed by #498
Open

[Bug Report] The links is so blurry unless set this.graph.config.links_ontop to true, on HiDPI screens. #497

cesaryuan opened this issue Sep 4, 2024 · 0 comments · May be fixed by #498

Comments

@cesaryuan
Copy link

cesaryuan commented Sep 4, 2024 •
edited
Loading

The links is so blurry unless we change if (this.graph.config.links_ontop) to if(true) in file src\litegraph.js line 7938.

litegraph.js/src/litegraph.js

Line 7938 in 0555a2f

if (this.graph.config.links_ontop) {

Reproduce steps:

  1. git clone https://github.com/jagenjo/litegraph.js.git
  2. cd litegraph.js
  3. npm install
  4. node utils/server.js
  5. Open Copy Paste demo.
  6. We can see that the links is blurry.
  7. Change if (this.graph.config.links_ontop) to if(true) in file src\litegraph.js line 7938.
  8. Reload page and Open Copy Paste demo.
  9. We can see that the links is clear.

Before image vs Afterimage

Upate: I just found the problem where it is. This is because we only scale the foreground canvas, but not the background canvas.
@cesaryuan cesaryuan linked a pull request Sep 4, 2024 that will close this issue
Open
@cesaryuan cesaryuan changed the title [Bug Report] The links is so blurry unless set this.graph.config.links_ontop to true, on 4k high DPI screens. [Bug Report] The links is so blurry unless set this.graph.config.links_ontop to true, on HiDPI screens. Sep 4, 2024
@cesaryuan cesaryuan mentioned this issue Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix blurry links on HiDPI screens cesaryuan/litegraph.js-original
1 participant
@cesaryuan